From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc, mpc5xxx: fix missing bootflag init
Date: Fri, 8 Jan 2016 09:07:32 +0100 [thread overview]
Message-ID: <568F6E44.7090702@denx.de> (raw)
In-Reply-To: <20160107193053.88101380311@gemini.denx.de>
Hello Wolfgang, York,
Am 07.01.2016 um 20:30 schrieb Wolfgang Denk:
> Dear York,
>
> In message <AM4PR0401MB1732D7EBA1C64E62F3A403449AF50@AM4PR0401MB1732.eurprd04.prod.outlook.com> you wrote:
>>
>>> So board_init_f gets a undefined bootflag,
>>> currently the gd pointer address. Unfortunately
>>> this address sets the GD_FLG_SKIP_RELOC bit,
>>> so u-boot code gets not relocated and u-boot
>>> does not boot ...
>>>
>>> Init bootflag with 0, and tqm5200 boots fine again.
> ...
>> Applied to u-boot-mpc85x. Merged upstream.
>
> Thanmks - but I think this needs a follow-up patch - Heiko is already
> looking into that. On closer inspection it appears as if the whole
> passing around of "bootflag" variables is just dead code - there is no
> place anywhere in U-Boot that makes real use of this data. We should
> remove all of the related code, which will make the code cleaner and
> smaller - which might be especially welcome in a number of SPL
> configurations.
Yes, I am trying to look into it ...
BTW: Now with this patch applied, automated tbot test [1] is now green
-> tqm5200 board works again with current mainline :-D
bye,
Heiko
[1] http://xeidos.ddns.net/buildbot/builders/tqm5200s_ml_ub
log:
http://xeidos.ddns.net/buildbot/builders/tqm5200s_ml_ub/builds/20/steps/shell/logs/tbotlog
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2016-01-08 8:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 8:46 [U-Boot] [PATCH] powerpc, mpc5xxx: fix missing bootflag init Heiko Schocher
2015-11-26 17:49 ` Simon Glass
2015-11-27 5:23 ` Heiko Schocher
2015-11-27 18:28 ` Simon Glass
2016-01-07 16:58 ` york sun
2016-01-07 19:30 ` Wolfgang Denk
2016-01-08 8:07 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568F6E44.7090702@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox