From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 8 Jan 2016 09:07:32 +0100 Subject: [U-Boot] [PATCH] powerpc, mpc5xxx: fix missing bootflag init In-Reply-To: <20160107193053.88101380311@gemini.denx.de> References: <1448441179-6214-1-git-send-email-hs@denx.de> <20160107193053.88101380311@gemini.denx.de> Message-ID: <568F6E44.7090702@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, York, Am 07.01.2016 um 20:30 schrieb Wolfgang Denk: > Dear York, > > In message you wrote: >> >>> So board_init_f gets a undefined bootflag, >>> currently the gd pointer address. Unfortunately >>> this address sets the GD_FLG_SKIP_RELOC bit, >>> so u-boot code gets not relocated and u-boot >>> does not boot ... >>> >>> Init bootflag with 0, and tqm5200 boots fine again. > ... >> Applied to u-boot-mpc85x. Merged upstream. > > Thanmks - but I think this needs a follow-up patch - Heiko is already > looking into that. On closer inspection it appears as if the whole > passing around of "bootflag" variables is just dead code - there is no > place anywhere in U-Boot that makes real use of this data. We should > remove all of the related code, which will make the code cleaner and > smaller - which might be especially welcome in a number of SPL > configurations. Yes, I am trying to look into it ... BTW: Now with this patch applied, automated tbot test [1] is now green -> tqm5200 board works again with current mainline :-D bye, Heiko [1] http://xeidos.ddns.net/buildbot/builders/tqm5200s_ml_ub log: http://xeidos.ddns.net/buildbot/builders/tqm5200s_ml_ub/builds/20/steps/shell/logs/tbotlog -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany