From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 13 Jan 2016 16:24:42 +0100 Subject: [U-Boot] [PATCH v3 09/10] mvebu: Support Synology DS414 In-Reply-To: <20160113151335.GW3359@bill-the-cat> References: <1451050886-20124-1-git-send-email-phil@nwl.cc> <20151225134005.E3C356121B@mail.nwl.cc> <20160113151335.GW3359@bill-the-cat> Message-ID: <56966C3A.2080708@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On 13.01.2016 16:13, Tom Rini wrote: > On Fri, Dec 25, 2015 at 02:41:25PM +0100, Phil Sutter wrote: > >> This adds support for the MV78230 based DS414 NAS by Synology. The >> relevant bits have been extracted from the 'synogpl-5004-armadaxp' >> package Synology kindly published, garnished with a fair amount of >> trial-and-error. > > So, for the code: > > Reviewed-by: Tom Rini > > But most of what follows should be in the "log" side, ie after the --- > rather than the message itself. This can be fixed when applying, but if > you end up needing to respin please reword this part, thanks! I've already prepared a git branch, with all the pending Marvell mvebu related patches included. For Luka to pull from into the official Marvell U-boot git repo. And I've added Phil's patches as well. My personal feeling is, that all this additional text could be quite useful. That's why I would like to keep it in. But if you really feel that we should remove it, then I can definitely drop those passages. Just let me know what you think. Thanks, Stefan