public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kevin Smith <kevin.smith@elecsyscorp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] arm: mvebu: Add runtime boot-device detection
Date: Wed, 13 Jan 2016 16:12:02 +0000	[thread overview]
Message-ID: <56967756.8020605@elecsyscorp.com> (raw)
In-Reply-To: <1452330464-16386-3-git-send-email-sr@denx.de>

On 01/09/2016 03:07 AM, Stefan Roese wrote:
> @@ -100,14 +100,24 @@
>   #if defined(CONFIG_ARMADA_38X)
>   /* SAR values for Armada 38x */
>   #define CONFIG_SAR_REG		(MVEBU_REGISTER(0x18600))
> +
>   #define SAR_CPU_FREQ_OFFS	10
>   #define SAR_CPU_FREQ_MASK	(0x1f << SAR_CPU_FREQ_OFFS)
>   #define SAR_BOOT_DEVICE_OFFS	4
>   #define SAR_BOOT_DEVICE_MASK	(0x1f << SAR_BOOT_DEVICE_OFFS)
> +
> +#define BOOT_DEV_SEL_OFFS	4
> +#define BOOT_DEV_SEL_MASK	(0x1f << BOOT_DEV_SEL_OFFS)
> +
It is a little confusing that this is added incorrectly here, then 
corrected in the next patch ... could this just be added as 0x3f here?

> +#define BOOT_FROM_UART		0x28
> +#define BOOT_FROM_SPI		0x32
> +#define BOOT_FROM_MMC		0x30
> +#define BOOT_FROM_MMC_ALT	0x31
>

  reply	other threads:[~2016-01-13 16:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09  9:07 [U-Boot] [PATCH 1/4] arm: mvebu: Move SAR register defines into header Stefan Roese
2016-01-09  9:07 ` [U-Boot] [PATCH 2/4] arm: mvebu: Make local structs static const Stefan Roese
2016-01-09  9:07 ` [U-Boot] [PATCH 3/4] arm: mvebu: Add runtime boot-device detection Stefan Roese
2016-01-13 16:12   ` Kevin Smith [this message]
2016-01-13 16:18     ` Stefan Roese
2016-01-13 16:34       ` Kevin Smith
2016-01-09  9:07 ` [U-Boot] [PATCH 4/4] arm: mvebu: Add runtime detection of UART (xmodem) boot-mode Stefan Roese
2016-01-09 13:03   ` Phil Sutter
2016-01-09 16:36     ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56967756.8020605@elecsyscorp.com \
    --to=kevin.smith@elecsyscorp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox