From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Smith <kevin.smith@elecsyscorp.com>
Date: Wed, 13 Jan 2016 16:34:03 +0000
Subject: [U-Boot] [PATCH 3/4] arm: mvebu: Add runtime boot-device
	detection
In-Reply-To: <569678F1.8090607@denx.de>
References: <1452330464-16386-1-git-send-email-sr@denx.de>
 <1452330464-16386-3-git-send-email-sr@denx.de>
 <56967756.8020605@elecsyscorp.com> <569678F1.8090607@denx.de>
Message-ID: <56967C7F.4060607@elecsyscorp.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/13/2016 10:18 AM, Stefan Roese wrote:
> On 13.01.2016 17:12, Kevin Smith wrote:
>> On 01/09/2016 03:07 AM, Stefan Roese wrote:
>>> @@ -100,14 +100,24 @@
>>>    #if defined(CONFIG_ARMADA_38X)
>>>    /* SAR values for Armada 38x */
>>>    #define CONFIG_SAR_REG        (MVEBU_REGISTER(0x18600))
>>> +
>>>    #define SAR_CPU_FREQ_OFFS    10
>>>    #define SAR_CPU_FREQ_MASK    (0x1f << SAR_CPU_FREQ_OFFS)
>>>    #define SAR_BOOT_DEVICE_OFFS    4
>>>    #define SAR_BOOT_DEVICE_MASK    (0x1f << SAR_BOOT_DEVICE_OFFS)
>>> +
>>> +#define BOOT_DEV_SEL_OFFS    4
>>> +#define BOOT_DEV_SEL_MASK    (0x1f << BOOT_DEV_SEL_OFFS)
>>> +
>> It is a little confusing that this is added incorrectly here, then
>> corrected in the next patch ... could this just be added as 0x3f here?
>
> Ah, right. I've fixed this define in the next patch:
>
> arm: mvebu: Add runtime detection of UART (xmodem) boot-mode
>
> Which is already waiting for upstreaming as well (once Luka picks it
> up). I hope this is okay. Otherwise I would need to re-do those
> patches again.
>
> Thanks,
> Stefan
>
Oh, sure, no problem.  Not worth redoing that work.

Thanks,
Kevin