From mboxrd@z Thu Jan 1 00:00:00 1970 From: Purna Chandra Mandal Date: Thu, 14 Jan 2016 15:59:01 +0530 Subject: [U-Boot] [PATCH v3 13/14] drivers: net: Add ethernet driver for Microchip PIC32. In-Reply-To: <20160113145632.GM3359@bill-the-cat> References: <1452593909-16184-1-git-send-email-purna.mandal@microchip.com> <1452593909-16184-14-git-send-email-purna.mandal@microchip.com> <20160113145632.GM3359@bill-the-cat> Message-ID: <5697786D.9040009@microchip.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/13/2016 08:26 PM, Tom Rini wrote: > On Tue, Jan 12, 2016 at 03:48:28PM +0530, Purna Chandra Mandal wrote: > >> This driver implements MAC and MII layer of the ethernet controller. >> Network data transfer is handled by controller internal DMA engine. >> Ethernet controller is configurable through device-tree file. >> >> Signed-off-by: Purna Chandra Mandal > [snip] >> +/* cache operation helper */ >> +#define __dcache_flush(__a, __l) \ >> + flush_dcache_range((ulong)(__a), ((__l) + (ulong)(__a))) >> + >> +#define __dcache_invalidate(__a, __l) \ >> + invalidate_dcache_range((ulong)(__a), ((__l) + (ulong)(__a))) > Why using these helper functions instead of directly? Yes, we may be > casting in some cases and if that's how it must be, so be it (it's how > we're doing it in other drivers). Thanks! Thanks, Will drop these helpers/macros.