From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v7, 2/2] arm: move gd handling outside of C code
Date: Thu, 14 Jan 2016 11:35:39 -0700 [thread overview]
Message-ID: <5697EA7B.8000204@wwwdotorg.org> (raw)
In-Reply-To: <20160114132044.GE3359@bill-the-cat>
On 01/14/2016 06:20 AM, Tom Rini wrote:
> On Wed, Nov 25, 2015 at 05:56:33PM +0100, Albert ARIBAUD wrote:
>
>> As of gcc 5.2.1 for Thumb-1, it is not possible any
>> more to assign gd from C code, as gd is mapped to r9,
>> and r9 may now be saved in the prolog sequence, and
>> restored in the epilog sequence, of any C functions.
>>
>> Therefore arch_setup_gd(), which is supposed to set
>> r9, may actually have no effect, causing U-Boot to
>> use a bad address to access GD.
>>
>> Fix this by never calling arch_setup_gd() for ARM,
>> and instead setting r9 in arch/arm/lib/crt0.S, to
>> the value returned by board_init_f_alloc_reserve().
>>
>> Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Applied to u-boot/master, thanks!
FYI, this commit causes U-Boot to fail (crash or hang during very early
startup with zero UART output) on at least an NVIDIA Jetson TX1
(p2371-2180) board. Reverting just this in u-boot/master solves the
issue. I have not tested other boards or looked at the code itself yet.
(As an interesting datapoint, this is the first issue caught by the
Jenkins system I'm setting up to run test/py on a few Tegra boards)
next prev parent reply other threads:[~2016-01-14 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 16:56 [U-Boot] [PATCH v7 1/2] Fix board init code to respect the C runtime environment Albert ARIBAUD
2015-11-25 16:56 ` [U-Boot] [PATCH v7 2/2] arm: move gd handling outside of C code Albert ARIBAUD
2015-11-27 2:51 ` Simon Glass
2016-01-14 13:20 ` [U-Boot] [U-Boot, v7, " Tom Rini
2016-01-14 18:35 ` Stephen Warren [this message]
2016-01-14 19:11 ` Tom Rini
2016-01-14 19:27 ` Stephen Warren
2016-01-14 19:45 ` Tom Rini
2016-01-14 20:48 ` Stephen Warren
2015-11-27 2:51 ` [U-Boot] [PATCH v7 1/2] Fix board init code to respect the C runtime environment Simon Glass
2015-11-29 6:13 ` Thomas Chou
2016-01-14 13:20 ` [U-Boot] [U-Boot, v7, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697EA7B.8000204@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox