public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] arm: colibri-vf: Enable serial support
Date: Fri, 22 Jan 2016 17:51:45 +0530	[thread overview]
Message-ID: <56A21ED9.9070706@toradex.com> (raw)
In-Reply-To: <CAEUhbmXADWdWYipq9Q_EnFK-ZT20Ao8VZEWRCvSAQc--YyxnRg@mail.gmail.com>

Hi Bin,

On 01/22/2016 03:22 PM, Bin Meng wrote:
> Hi Bhuvanchandra,
>
> On Fri, Jan 22, 2016 at 3:49 PM, Bhuvanchandra DV
> <bhuvanchandra.dv@toradex.com> wrote:
>> ---
>
> Please always include a commit message.

Okay

>
>>   arch/arm/dts/vf-colibri.dtsi     | 10 ++++++++++
>>   configs/colibri_vf_dtb_defconfig |  1 +
>>   2 files changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/dts/vf-colibri.dtsi b/arch/arm/dts/vf-colibri.dtsi
>> index 7a8e9bee..0718486 100644
>> --- a/arch/arm/dts/vf-colibri.dtsi
>> +++ b/arch/arm/dts/vf-colibri.dtsi
>> @@ -10,6 +10,12 @@
>>    */
>>   #include "vf.dtsi"
>>
>> +/ {
>> +       chosen {
>> +               stdout-path = &uart0;
>> +       };
>> +};
>> +
>>   &dspi1 {
>>          status = "okay";
>>          bus-num = <1>;
>> @@ -19,3 +25,7 @@
>>                  spi-max-frequency = <50000000>;
>>          };
>>   };
>> +
>> +&uart0 {
>> +       status = "okay";
>> +};
>> diff --git a/configs/colibri_vf_dtb_defconfig b/configs/colibri_vf_dtb_defconfig
>
> Why adding _dtb here? Can we update the existing defconfig files?
>
>> index b1a843a..b204fb8 100644
>> --- a/configs/colibri_vf_dtb_defconfig
>> +++ b/configs/colibri_vf_dtb_defconfig
>> @@ -11,4 +11,5 @@ CONFIG_OF_CONTROL=y
>>   CONFIG_DM=y
>>   CONFIG_NAND_VF610_NFC=y
>>   CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y
>> +CONFIG_DM_SERIAL=y
>>   CONFIG_FSL_LPUART=y
>> --
>
> Please try to insert new Kconfig options in a correct order. You can
> get it via 'make savedefconfig'.

Will do it.

>
> Regards,
> Bin
>

-- 
Best regards,
Bhuvan

  reply	other threads:[~2016-01-22 12:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22  7:49 [U-Boot] [PATCH 0/7] Add/enable lpuart support on Vybrid based boards Bhuvanchandra DV
2016-01-22  7:49 ` [U-Boot] [PATCH 1/7] arm: vf: Enable lpuart support Bhuvanchandra DV
2016-01-22  9:52   ` Bin Meng
2016-01-22  7:49 ` [U-Boot] [PATCH 2/7] arm: colibri-vf: Enable serial support Bhuvanchandra DV
2016-01-22  9:52   ` Bin Meng
2016-01-22 12:21     ` Bhuvanchandra DV [this message]
2016-01-22  7:49 ` [U-Boot] [PATCH 3/7] arm: vf610-twr: Add device tree files Bhuvanchandra DV
2016-01-22  9:52   ` Bin Meng
2016-01-22 12:21     ` Bhuvanchandra DV
2016-01-22  7:49 ` [U-Boot] [PATCH 4/7] arm: pcm052: " Bhuvanchandra DV
2016-01-22  9:53   ` Bin Meng
2016-01-22  7:49 ` [U-Boot] [PATCH 5/7] dm: lpuart: Drop the legacy code Bhuvanchandra DV
2016-01-22  9:54   ` Bin Meng
2016-01-22  7:49 ` [U-Boot] [PATCH 6/7] arm: vybrid: Drop enabling serial in legacy mode Bhuvanchandra DV
2016-01-22  9:54   ` Bin Meng
2016-01-22  7:49 ` [U-Boot] [PATCH 7/7] arm: vf: Remove the legacy defconfigs Bhuvanchandra DV
2016-01-22  9:55   ` Bin Meng
2016-01-22 12:21     ` Bhuvanchandra DV
2016-01-22 16:38       ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A21ED9.9070706@toradex.com \
    --to=bhuvanchandra.dv@toradex.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox