From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: restore initialization for DM_PCI
Date: Fri, 22 Jan 2016 12:35:56 -0700 [thread overview]
Message-ID: <56A2849C.30203@wwwdotorg.org> (raw)
In-Reply-To: <CAEUhbmVaFgvspcc7Uo28tiDDTxEgor4zwHA7tT38tz9_Q4+ObA@mail.gmail.com>
On 01/21/2016 06:39 PM, Bin Meng wrote:
> Hi Stephen,
>
> On Fri, Jan 22, 2016 at 7:35 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> PCI controllers should be enumerated at startup so that PCI devices
>> such as Ethernet controllers are available at startup. Fix board_init_r()
>> not to skip calling pci_init() when CONFIG_DM_PCI is defined, and provide
>> an implementation of pci_init() for the DM case.
>>
>
> What exact issue are you trying to fix? I posted the same question on
> Simon's patch [1] before. Does your patch and Simon's fix the same
> issue?
...
> [1] http://patchwork.ozlabs.org/patch/569323/
Oh, I hadn't seen that patch. That patch seems to only probe the first
PCI controller/port, which still leaves all the other controllers/ports
non-operational.
The issue is this: The PCI driver never gets probed. This used to happen
because all Ethernet drivers were probed, and the Ethernet drivers would
call into PCI APIs to determine if PCI devices exist, which would then
trigger the PCI driver to be probed.
However with the current code-base, nothing probes the PCI controller
driver, so the entire bus enumeration process never happens. Since
there's no way (e.g. shell command) to force the PCI device/driver to
probe, it's currently impossible to use any PCI device.
This patch restores the original behaviour of probing all PCI
controllers automatically at boot.
next prev parent reply other threads:[~2016-01-22 19:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 23:35 [U-Boot] [PATCH] pci: restore initialization for DM_PCI Stephen Warren
2016-01-22 0:30 ` Tom Rini
2016-01-22 1:39 ` Bin Meng
2016-01-22 3:36 ` Simon Glass
2016-01-22 3:53 ` Bin Meng
2016-01-22 4:03 ` Simon Glass
2016-01-22 4:06 ` Bin Meng
2016-01-22 4:17 ` Simon Glass
2016-01-22 19:38 ` Stephen Warren
2016-01-22 20:32 ` Simon Glass
2016-01-22 21:48 ` Stephen Warren
2016-01-22 21:50 ` Simon Glass
2016-01-22 21:58 ` Stephen Warren
2016-01-22 22:00 ` Simon Glass
2016-01-25 17:11 ` Stephen Warren
2016-01-26 0:57 ` Simon Glass
2016-01-24 12:23 ` Bin Meng
2016-01-22 19:35 ` Stephen Warren [this message]
2016-01-22 15:49 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A2849C.30203@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox