From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] atmel_nand: add '\n' in the end of error message for better display
Date: Sun, 24 Jan 2016 22:31:23 +0100 [thread overview]
Message-ID: <56A542AB.9050504@googlemail.com> (raw)
In-Reply-To: <1448353614-26398-3-git-send-email-josh.wu@atmel.com>
Hi Josh,
On 24.11.15 09:26, Josh Wu wrote:
> Also align the open parenthesis.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>
> drivers/mtd/nand/atmel_nand.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e179f74..5226acf 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -821,8 +821,8 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
> * from ONFI.
> */
> if (pmecc_choose_ecc(host, nand, &cap, §or_size)) {
> - dev_err(host->dev, "The NAND flash's ECC requirement(ecc_bits: %d, sector_size: %d) are not support!",
> - cap, sector_size);
> + dev_err(host->dev, "The NAND flash's ECC requirement(ecc_bits: %d, sector_size: %d) are not support!\n",
> + cap, sector_size);
Could you please rephrase this?
NAND flash's ECC requirement (ecc_bits: %d, sector_size: %d) is not
supported!
or since dev_err() should print pmecc in any case:
Required ECC %d bits in %d bytes not supported!
Andreas
> return -EINVAL;
> }
>
>
next prev parent reply other threads:[~2016-01-24 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 8:26 [U-Boot] [PATCH 0/4] atmel_nand: misc update in atmel nandflash driver Josh Wu
2015-11-24 8:26 ` [U-Boot] [PATCH 1/4] atmel_nand: use nand ecc_{strength, step}_ds instead of our own function Josh Wu
2016-01-24 21:22 ` Andreas Bießmann
2016-01-25 2:41 ` Yang, Wenyou
2015-11-24 8:26 ` [U-Boot] [PATCH 2/4] atmel_nand: add '\n' in the end of error message for better display Josh Wu
2016-01-24 21:31 ` Andreas Bießmann [this message]
2015-11-24 8:26 ` [U-Boot] [PATCH 3/4] atmel_nand: increase more delay to support MT29F32G08CBADA Josh Wu
2016-01-24 21:41 ` Andreas Bießmann
2016-01-25 5:51 ` Yang, Wenyou
2015-11-24 8:26 ` [U-Boot] [PATCH 4/4] atmel_nand: use the definition: PMECC_OOB_RESERVED_BYTES instead magic number Josh Wu
2016-01-24 21:37 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A542AB.9050504@googlemail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox