From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] test/py: move find_ram_base() into u_boot_utils
Date: Mon, 25 Jan 2016 09:50:08 -0700 [thread overview]
Message-ID: <56A65240.9090108@wwwdotorg.org> (raw)
In-Reply-To: <20160122223011.E743A3811CD@gemini.denx.de>
On 01/22/2016 03:30 PM, Wolfgang Denk wrote:
> Dear Stephen,
>
> In message <1453417531-23669-1-git-send-email-swarren@wwwdotorg.org> you wrote:
>>
>> find_ram_base() is a shared utility function, not a core part of the
>> U-Boot console interaction.
>
> On which boards did you test this feature? Eventually ARM only?
It's been tested on a few ARM, sandbox, and at least one microblaze.
>> + with u_boot_console.log.section('find_ram_base'):
>> + response = u_boot_console.run_command('bdinfo')
>> + for l in response.split('\n'):
>> + if '-> start' in l:
>> + ram_base = int(l.split('=')[1].strip(), 16)
>> + break
>
> Searching for "-> start" is probably not exactly portable. For
> example, on a PowerPC system the output of "bdi" might look like this:
>
> => bdi
> memstart = 0x00000000
> memsize = 0x04000000
...
>
> [example is from a TQM5200S, U-Boot 2016.01-00223-gb57843e]
Good point. I think the best fix here is to modify all implementations
of "bdinfo" to print the same information and in the same format as much
as possible. Do you agree?
next prev parent reply other threads:[~2016-01-25 16:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 23:05 [U-Boot] [PATCH 1/2] test/py: move find_ram_base() into u_boot_utils Stephen Warren
2016-01-21 23:05 ` [U-Boot] [PATCH 2/2] test/py: add a networking test Stephen Warren
2016-01-22 3:36 ` Simon Glass
2016-01-26 1:15 ` Simon Glass
2016-01-22 3:36 ` [U-Boot] [PATCH 1/2] test/py: move find_ram_base() into u_boot_utils Simon Glass
2016-01-22 22:30 ` Wolfgang Denk
2016-01-25 16:50 ` Stephen Warren [this message]
2016-01-26 1:03 ` Simon Glass
2016-01-26 1:09 ` Stephen Warren
2016-01-26 1:15 ` Simon Glass
2016-01-26 18:13 ` Stephen Warren
2016-01-26 19:59 ` Simon Glass
2016-01-26 20:08 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A65240.9090108@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox