From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 26 Jan 2016 15:11:58 +0100 Subject: [U-Boot] [PATCH 1/2] imx: mx6sx: Fix issue in LCDIF clock enablement In-Reply-To: <1453816918-25383-1-git-send-email-ye.li@nxp.com> References: <1453816918-25383-1-git-send-email-ye.li@nxp.com> Message-ID: <56A77EAE.6020301@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 26/01/2016 15:01, Ye Li wrote: > Wrong checking for the base_addr paramter with LCDIF1 and LCDIF2. Always > enter the -EINVAL return. > > Signed-off-by: Ye Li > --- > arch/arm/cpu/armv7/mx6/clock.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c > index 27a3f2f..007204d 100644 > --- a/arch/arm/cpu/armv7/mx6/clock.c > +++ b/arch/arm/cpu/armv7/mx6/clock.c > @@ -742,8 +742,8 @@ int enable_lcdif_clock(u32 base_addr) > u32 lcdif_clk_sel_mask, lcdif_ccgr3_mask; > > if (is_cpu_type(MXC_CPU_MX6SX)) { > - if ((base_addr == LCDIF1_BASE_ADDR) || > - (base_addr == LCDIF2_BASE_ADDR)) { > + if ((base_addr != LCDIF1_BASE_ADDR) && > + (base_addr != LCDIF2_BASE_ADDR)) { > puts("Wrong LCD interface!\n"); > return -EINVAL; > } > Reviewed-by: Stefano Babic Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================