public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rpi: fix up Model B entries
Date: Tue, 26 Jan 2016 20:39:10 -0700	[thread overview]
Message-ID: <56A83BDE.1010801@wwwdotorg.org> (raw)
In-Reply-To: <1453754191-2996-1-git-send-email-lkundrak@v3.sk>

On 01/25/2016 01:36 PM, Lubomir Rintel wrote:
> It seems like the P5 header was not present on "Model B" any board prior
> to Revision 2.0, there's no need for a separate device tree.
> 
> Also, it looks like "rev2" is incorrectly used to only cover the 512MiB
> memory models; there also were 256MiB 2.0 boards.
> 
> I don't have all of the boards to check this, I'm following this table:
> http://elinux.org/RPi_HardwareHistory#Board_Revision_History

Yes, I believe this makes sense, and is consistent with the URLs listed
as data sources just a little above the model table.

I tested this patch on board rev 0x2 (B, no P5/rev1, 256M), 0x8 (A,
256M), 0xf (B, P5/rev2, 512M).

Acked-by: Stephen Warren <swarren@wwwdotorg.org>

It would be really nice if you could get someone at the Pi Foundation to
validate the complete updated tables (at least, the revision number to
model name mapping) in this file after this patch. I CC'd Gordon and Dom
to see if one of them could do that, or track someone down who can.
Gordon, Dom, you can find the file content at:

> https://github.com/swarren/u-boot/blob/rpi_dev/board/raspberrypi/rpi/rpi.c#L98

P.S. Lubomir, I used my personal email swarren at wwwdotorg.org for RPi
work, not my work email swarren at nvidia.com.

Thanks for working on cleaning this up.

  reply	other threads:[~2016-01-27  3:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 20:36 [U-Boot] [PATCH] rpi: fix up Model B entries Lubomir Rintel
2016-01-27  3:39 ` Stephen Warren [this message]
2016-01-27 14:47   ` popcorn mix
2016-01-29  5:22 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A83BDE.1010801@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox