[U-Boot] [PATCH 2/7] fdt: Build a U-Boot binary without device tree

Simon Glass
2016-01-25T21:18:52Z

Hi Stephen,

On 25 January 2016 at 14:14, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 01/25/2016 01:30 PM, Simon Glass wrote:
>>
>> At present u-boot.bin holds the plain U-Boot binary without the device
>> tree.
>> This is somewhat annoying since you need either u-boot.bin or
>> u-boot-dtb.bin
>> depending on whether device tree is used.
>>
>> Adjust the build such that u-boot.bin includes a device tree, and the
>> plain binary is in u-boot-nodtb.bin. For now u-boot-dtb.bin remains the
>> same.
>>
>> This should be acceptable since:
>>
>> - without OF_CONTROL, u-boot.bin still does not include a device tree
>> - with OF_CONTROL, u-boot-dtb.bin does not change
>>
>> The main impact is build systems which are set up to use u-boot.bin as
>> the output file and then add a device tree. These will have to change to
>> use
>> u-boot-nodtb.bin instead.
>
>
> That's probably going to annoy somebody. Have you put thought into how such
> a build system could auto-detect which file it should use in order to
> automatically adjust to the different file naming conventions of different
> U-Boot versions or branches? If not, this change will burden the operator of
> any tool or automated system with manually handling the difference by
> branching their own code or processes:-(

Well we cannot know what downstream build systems do, but I think my
reasoning is about right.

>
>> Adjust tegra rules so it continues to produce the correct files.
>
>
> I don't see anything Tegra-related in this patch. Perhaps patch 1/7 was
> included here in a previous version and the commit description not updated?

Yes, somehow I managed to send out the wrong branch. A few commit
messages are out of date but the code is the same. I'll fix it with v2
once I get some comments.

> Anyway, I think this patch doesn't affect me or Tegra's flashing tools. For
> reference, the tool currently uses the following files:
>
> u-boot
> spl/u-boot-spl
> u-boot-nodtb-tegra.bin
> u-boot.dtb
> u-boot-dtb-tegra.bin
>

Regards,
Simon