From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] x86: x86-common.h: Add CONFIG_BOOTDELAY
Date: Thu, 28 Jan 2016 16:04:25 +0100 [thread overview]
Message-ID: <56AA2DF9.7020206@denx.de> (raw)
In-Reply-To: <CAEUhbmXMA5UASPcOW_YUn=H6f6w9q1_9=8tsoBRB64YWPa0r0g@mail.gmail.com>
Hi Bin,
On 26.01.2016 07:48, Bin Meng wrote:
> On Tue, Jan 19, 2016 at 2:19 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Mon, Jan 18, 2016 at 9:49 PM, Stefan Roese <sr@denx.de> wrote:
>>> Without this CONFIG_BOOTDELAY, autobooting does not work at all. As
>>> autoboot_command() from common/* will not get called. So lets define
>>> CONFIG_BOOTDELAY, so that auto-booting works on x86.
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Cc: Miao Yan <yanmiaobest@gmail.com>
>>> Cc: Bin Meng <bmeng.cn@gmail.com>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> ---
>>> include/configs/x86-common.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>
>> Acked-by: Bin Meng <bmeng.cn@gmail.com>
>
> Sorry, this patch does not build for efi-x86.
>
> x86: + efi-x86
> +../common/autoboot.c: In function 'process_fdt_options':
> +../common/autoboot.c:296:36: error: 'CONFIG_SYS_TEXT_BASE' undeclared
> (first use in this function)
> + setenv_addr("kernaddr", (void *)(CONFIG_SYS_TEXT_BASE + addr));
> + ^
> +../common/autoboot.c:296:36: note: each undeclared identifier is
> reported only once for each function it appears in
> +make[2]: *** [common/autoboot.o] Error 1
> +make[1]: *** [common] Error 2
> +make: *** [sub-make] Error 2
>
> Could you please fix this? Sorry I did not run buildman earlier.
No need to be sorry for you. I should have spotted this problem before
submitting. I'll fix this soon and will resubmit.
Thanks,
Stefan
next prev parent reply other threads:[~2016-01-28 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 13:49 [U-Boot] [PATCH 1/2] x86: x86-common.h: Add CONFIG_BOOTDELAY Stefan Roese
2016-01-18 13:49 ` [U-Boot] [PATCH 2/2] x86: x86-common.h: Add generic FS commands Stefan Roese
2016-01-19 6:19 ` Bin Meng
2016-01-26 6:48 ` Bin Meng
2016-01-19 5:20 ` [U-Boot] [PATCH 1/2] x86: x86-common.h: Add CONFIG_BOOTDELAY Miao Yan
2016-01-19 6:19 ` Bin Meng
2016-01-26 6:48 ` Bin Meng
2016-01-28 15:04 ` Stefan Roese [this message]
2016-01-28 16:13 ` Stefan Roese
2016-01-28 16:16 ` Simon Glass
2016-01-28 16:18 ` Stefan Roese
2016-01-29 8:43 ` Bin Meng
2016-01-19 17:25 ` Tom Rini
2016-01-21 6:06 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA2DF9.7020206@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox