From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: tegra: rm Jetson TK1 PMIC GPIO programming
Date: Thu, 28 Jan 2016 10:11:02 -0700 [thread overview]
Message-ID: <56AA4BA6.4040406@wwwdotorg.org> (raw)
In-Reply-To: <3a053560b0874c70867c39bb95d66bfe@HQMAIL103.nvidia.com>
On 01/18/2016 12:16 PM, Tom Warren wrote:
> Stephen Warren wrotea tMonday, January 18, 2016 11:23 AM:
>> The PMIC is configured such that its GPIOs have the correct configuration at
>> power-up, so no programming is required.
>>
>> In fact, the current programming is actively wrong, since:
>>
>> (a) the AS3722 driver configures the GPIO to be an output before setting its
>> output value, which causes a 0v glitch on the output.
>>
>> (b) the AS3722 driver configures the GPIO to drive a high voltage from its
>> VSUP_GPIO power source rather than its VDD_GPIO_LV power source, so the
>> pin drives 5V not 1.8V as desired.
>>
>> Solve these problems by removing the code which configures the PMIC GPIOs.
>>
>> Note that this patch was tested directly on top of v2016.01; since then, commit
>> 96350f729c42 "dm: tegra: net: Convert tegra boards to driver model for
>> Ethernet" prevents PCIe from being initialized. Alternatively, simply revert that
>> commit to get PCIe Ethernet working again, then apply this patch to test.
>>
> Acked-by: Tom Warren <twarren@nvidia.com>
> I'll apply this to u-boot-tegra/next ASAP.
I don't see this patch there yet. It'd be good to get it pulled upstream
ASAP since the merge window for v2016.03 closes this weekend.
next prev parent reply other threads:[~2016-01-28 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 18:23 [U-Boot] [PATCH] ARM: tegra: rm Jetson TK1 PMIC GPIO programming Stephen Warren
2016-01-18 19:16 ` Tom Warren
2016-01-28 17:11 ` Stephen Warren [this message]
2016-01-28 17:30 ` Tom Warren
2016-01-19 13:10 ` Thierry Reding
2016-01-22 15:52 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA4BA6.4040406@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox