public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test/py: make each unit test a pytest
Date: Thu, 28 Jan 2016 22:08:22 -0700	[thread overview]
Message-ID: <56AAF3C6.1030605@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ1rKMaq6=qN+wx0rpzgbtZ1YyO1wg=xpcQ3bi-kL-nFwg@mail.gmail.com>

On 01/28/2016 08:52 PM, Simon Glass wrote:
> Hi Stephen,
> 
> On 28 January 2016 at 16:45, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> A custom fixture named ut_subtest is implemented which is parametrized
>> with the names of all unit tests that the U-Boot binary supports. This
>> causes each U-Boot unit test to be exposes as a separate pytest. In turn,
>> this allows more fine-grained pass/fail counts and test selection, e.g.:
>>
>> test.py --bd sandbox -k ut_dm_usb
>>
>> ... will run about 8 tests at present.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> This depends on at least my recently sent "test/py: run C-based unit tests".
>>
>>  test/py/conftest.py      | 105 ++++++++++++++++++++++++++++++++++++-----------
>>  test/py/tests/test_ut.py |  14 +++----
>>  2 files changed, 86 insertions(+), 33 deletions(-)
> 
> This seems a bit extreme. It might be better to move the remaining
> three commands under the 'ut' subcommand. Then all unit tests would be
> visible from the 'ut' help...

I'm not sure what you mean by "extreme"? Do you mean you don't want each
unit test exposed as a separate pytest? I thought based on our previous
conversation that was exactly what you wanted. If not, I'm not sure what
the deficiency in the current code is; either all the dm subtests are
executed at once by a single pytest with a single overall status, or
they're each a separate pytest with individual status. Any grouping
that's in between those seems like it would be entirely arbitrary?

  reply	other threads:[~2016-01-29  5:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 23:45 [U-Boot] [PATCH] test/py: make each unit test a pytest Stephen Warren
2016-01-29  3:52 ` Simon Glass
2016-01-29  5:08   ` Stephen Warren [this message]
2016-01-29 18:23     ` Simon Glass
2016-01-29 18:48       ` Stephen Warren
2016-01-29 20:11         ` Simon Glass
2016-02-02 19:43           ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AAF3C6.1030605@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox