From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] autoboot.c: Fill env vars in process_fdt_options() only if TEXT_BASE is set
Date: Fri, 29 Jan 2016 09:31:04 +0100 [thread overview]
Message-ID: <56AB2348.8000204@denx.de> (raw)
In-Reply-To: <CAEUhbmUdnPgrNYs1Lo+kBxNEVHNrAXH6Ew+V-ifDMSHyFBFLzw@mail.gmail.com>
On 29.01.2016 09:27, Bin Meng wrote:
> Hi Stefan,
>
> On Fri, Jan 29, 2016 at 4:26 PM, Stefan Roese <sr@denx.de> wrote:
>> On 29.01.2016 09:24, Bin Meng wrote:
>>>
>>> On Fri, Jan 29, 2016 at 12:34 AM, Stefan Roese <sr@denx.de> wrote:
>>>>
>>>> The x86 build target "efi-x86" has no TEXT_BASE configured. And with the
>>>> introduction of CONFIG_BOOTDELAY for x86, this function is now called
>>>> for this board as well. Resulting in compile errors for this target.
>>>>
>>>> Without TEXT_BASE it makes no sense to fill these values. So lets only
>>>> configure the env variable if TEXT_BASE is defined.
>>>>
>>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>>> Cc: Simon Glass <sjg@chromium.org>
>>>> Cc: Bin Meng <bmeng.cn@gmail.com>
>>>> Cc: Tom Rini <trini@konsulko.com>
>>>> ---
>>>> common/autoboot.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>
>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>>
>>
>> Thanks Bin. Will you pick up the BOOTDELAY patch, once this patch
>> arrives in mainline? Or will you include this into your x86
>> branch as well?
>>
>
> I will take this to the x86 branch.
Thanks.
> Do you plan to submit your new
> baytrail board patches for this release?
Not sure yet. I'm still waiting for a confirmation that my DDR
memory down parameters are "correct". It seems to be working,
but I would like to get an ack from the board manufacturer here.
So it might still be a few days until these board patches hit
the mailing list.
Thanks,
Stefan
prev parent reply other threads:[~2016-01-29 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 16:34 [U-Boot] [PATCH] autoboot.c: Fill env vars in process_fdt_options() only if TEXT_BASE is set Stefan Roese
2016-01-29 0:18 ` Simon Glass
2016-01-29 8:43 ` Bin Meng
2016-01-29 8:24 ` Bin Meng
2016-01-29 8:26 ` Stefan Roese
2016-01-29 8:27 ` Bin Meng
2016-01-29 8:31 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AB2348.8000204@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox