From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 29 Jan 2016 09:31:04 +0100 Subject: [U-Boot] [PATCH] autoboot.c: Fill env vars in process_fdt_options() only if TEXT_BASE is set In-Reply-To: References: <1453998880-18338-1-git-send-email-sr@denx.de> <56AB224A.6090807@denx.de> Message-ID: <56AB2348.8000204@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 29.01.2016 09:27, Bin Meng wrote: > Hi Stefan, > > On Fri, Jan 29, 2016 at 4:26 PM, Stefan Roese wrote: >> On 29.01.2016 09:24, Bin Meng wrote: >>> >>> On Fri, Jan 29, 2016 at 12:34 AM, Stefan Roese wrote: >>>> >>>> The x86 build target "efi-x86" has no TEXT_BASE configured. And with the >>>> introduction of CONFIG_BOOTDELAY for x86, this function is now called >>>> for this board as well. Resulting in compile errors for this target. >>>> >>>> Without TEXT_BASE it makes no sense to fill these values. So lets only >>>> configure the env variable if TEXT_BASE is defined. >>>> >>>> Signed-off-by: Stefan Roese >>>> Cc: Simon Glass >>>> Cc: Bin Meng >>>> Cc: Tom Rini >>>> --- >>>> common/autoboot.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>> >>> Reviewed-by: Bin Meng >> >> >> Thanks Bin. Will you pick up the BOOTDELAY patch, once this patch >> arrives in mainline? Or will you include this into your x86 >> branch as well? >> > > I will take this to the x86 branch. Thanks. > Do you plan to submit your new > baytrail board patches for this release? Not sure yet. I'm still waiting for a confirmation that my DDR memory down parameters are "correct". It seems to be working, but I would like to get an ack from the board manufacturer here. So it might still be a few days until these board patches hit the mailing list. Thanks, Stefan