[U-Boot] [PATCH 00/14] EFI payload / application support v2

Simon Glass
2016-02-02T00:28:30Z

Hi Alex,

On 1 February 2016 at 17:16, Alexander Graf <agraf@suse.de> wrote:
>
>
>
> On 02/02/2016 01:02 AM, Simon Glass wrote:
>>
>> Hi Alex,
>>
>> On 1 February 2016 at 14:38, Alexander Graf <agraf@suse.de> wrote:
>>
>>>>>> For now I've had a play with Minnowboard, which is x86. The main thing
>>>>>> I noticed is that the API function implements should have EFIAPI on
>>>>>> them also.
>>>>>
>>>>>
>>>>> Yes :). I didn't expect anyone to actually care about running this on x86
>>>>> which is the only architecture that has different calling conventions for
>>>>> EFI. I'm very pleasantly surprised that you are interested and since you
>>>>> already have a patch to add them, I guess you can as well just post that
>>>>> once the base support is in :).
>>>>
>>>> OK. I suppose because EFIAPI is empty on ARM it doesn't matter. But
>>>> strictly speaking the declaration should match the implementation.
>>>
>>>
>>> Yeah, I just didn't want to implement something I wouldn't test :).
>>
>> OK. You could add a regparm(0) or something like that to be sure it is
>> working. Or just bring in that part of my patch. But I'm OK if you'd
>> rather I send a follow-up.
>
>
>
> My AArch64 compiler isn't really happy about that:
>
> include/efi_loader.h:67:4: warning: 'regparm' attribute directive ignored [-Wattributes]
>
> But I've fixed up everything I could find manually and just leave the remaining 1 or 2 occurrences to you :)

Sounds good, thanks.

Regards,
Simon