From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6slevk: Fix the reset delay for the the LAN8720 PHY
Date: Tue, 2 Feb 2016 21:20:33 +0100 [thread overview]
Message-ID: <56B10F91.20508@denx.de> (raw)
In-Reply-To: <1454332510-21860-1-git-send-email-festevam@gmail.com>
On 01/02/2016 14:15, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Since commit 59370f3fcd1350 ("net: phy: delay only if reset handler is
> registered") Ethernet is no longer functional.
>
> This commit does not have an issue in itself, but it revelead a problem
> with the Ethernet initialization.
>
> According to the LAN8720 datasheet tpurstd (time that reset line should
> stay asserted) is 25ms.
>
> So do as suggested in order to have Ethernet working again.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> board/freescale/mx6slevk/mx6slevk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
> index 5eab4b5..721ec21 100644
> --- a/board/freescale/mx6slevk/mx6slevk.c
> +++ b/board/freescale/mx6slevk/mx6slevk.c
> @@ -156,7 +156,7 @@ static void setup_iomux_fec(void)
>
> /* Reset LAN8720 PHY */
> gpio_direction_output(ETH_PHY_RESET , 0);
> - udelay(1000);
> + udelay(25000);
> gpio_set_value(ETH_PHY_RESET, 1);
> }
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2016-02-02 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 13:15 [U-Boot] [PATCH] mx6slevk: Fix the reset delay for the the LAN8720 PHY Fabio Estevam
2016-02-02 20:20 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B10F91.20508@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox