[U-Boot] [PATCH] mx6slevk: Fix the reset delay for the the LAN8720 PHY

[U-Boot] [PATCH] mx6slevk: Fix the reset delay for the the LAN8720 PHY

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Since commit 59370f3fcd1350 ("net: phy: delay only if reset handler is
registered") Ethernet is no longer functional.

This commit does not have an issue in itself, but it revelead a problem
with the Ethernet initialization.

According to the LAN8720 datasheet tpurstd (time that reset line should
stay asserted) is 25ms.

So do as suggested in order to have Ethernet working again.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/freescale/mx6slevk/mx6slevk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
index 5eab4b5..721ec21 100644
--- a/board/freescale/mx6slevk/mx6slevk.c
+++ b/board/freescale/mx6slevk/mx6slevk.c
@@ -156,7 +156,7 @@ static void setup_iomux_fec(void)
 
 	/* Reset LAN8720 PHY */
 	gpio_direction_output(ETH_PHY_RESET , 0);
-	udelay(1000);
+	udelay(25000);
 	gpio_set_value(ETH_PHY_RESET, 1);
 }
 
-- 
1.9.1

[U-Boot] [PATCH] mx6slevk: Fix the reset delay for the the LAN8720 PHY

[Stefano Babic]

On 01/02/2016 14:15, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Since commit 59370f3fcd1350 ("net: phy: delay only if reset handler is
> registered") Ethernet is no longer functional.
> 
> This commit does not have an issue in itself, but it revelead a problem
> with the Ethernet initialization.
> 
> According to the LAN8720 datasheet tpurstd (time that reset line should
> stay asserted) is 25ms.
> 
> So do as suggested in order to have Ethernet working again.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  board/freescale/mx6slevk/mx6slevk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
> index 5eab4b5..721ec21 100644
> --- a/board/freescale/mx6slevk/mx6slevk.c
> +++ b/board/freescale/mx6slevk/mx6slevk.c
> @@ -156,7 +156,7 @@ static void setup_iomux_fec(void)
>  
>  	/* Reset LAN8720 PHY */
>  	gpio_direction_output(ETH_PHY_RESET , 0);
> -	udelay(1000);
> +	udelay(25000);
>  	gpio_set_value(ETH_PHY_RESET, 1);
>  }


Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================