* [U-Boot] [PATCH] tqma6_wru4: Fix the reset delay for the the LAN8720 PHY
@ 2016-02-01 13:19 Fabio Estevam
2016-02-02 20:21 ` Stefano Babic
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2016-02-01 13:19 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@nxp.com>
According to the LAN8720 datasheet tpurstd (time that reset line should
stay asserted) is 25ms.
So do as suggested by the LAN8720 datasheet.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
board/tqc/tqma6/tqma6_wru4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/tqc/tqma6/tqma6_wru4.c b/board/tqc/tqma6/tqma6_wru4.c
index 4427799..c9a7ab7 100644
--- a/board/tqc/tqma6/tqma6_wru4.c
+++ b/board/tqc/tqma6/tqma6_wru4.c
@@ -177,7 +177,7 @@ static void setup_iomuxc_enet(void)
ret = gpio_request(ENET_PHY_RESET_GPIO, "phy-reset");
if (!ret)
gpio_direction_output(ENET_PHY_RESET_GPIO , 0);
- udelay(1000);
+ udelay(25000);
gpio_set_value(ENET_PHY_RESET_GPIO, 1);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] tqma6_wru4: Fix the reset delay for the the LAN8720 PHY
2016-02-01 13:19 [U-Boot] [PATCH] tqma6_wru4: Fix the reset delay for the the LAN8720 PHY Fabio Estevam
@ 2016-02-02 20:21 ` Stefano Babic
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Babic @ 2016-02-02 20:21 UTC (permalink / raw)
To: u-boot
On 01/02/2016 14:19, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> According to the LAN8720 datasheet tpurstd (time that reset line should
> stay asserted) is 25ms.
>
> So do as suggested by the LAN8720 datasheet.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> board/tqc/tqma6/tqma6_wru4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/tqc/tqma6/tqma6_wru4.c b/board/tqc/tqma6/tqma6_wru4.c
> index 4427799..c9a7ab7 100644
> --- a/board/tqc/tqma6/tqma6_wru4.c
> +++ b/board/tqc/tqma6/tqma6_wru4.c
> @@ -177,7 +177,7 @@ static void setup_iomuxc_enet(void)
> ret = gpio_request(ENET_PHY_RESET_GPIO, "phy-reset");
> if (!ret)
> gpio_direction_output(ENET_PHY_RESET_GPIO , 0);
> - udelay(1000);
> + udelay(25000);
> gpio_set_value(ENET_PHY_RESET_GPIO, 1);
> }
>
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-02 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 13:19 [U-Boot] [PATCH] tqma6_wru4: Fix the reset delay for the the LAN8720 PHY Fabio Estevam
2016-02-02 20:21 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox