public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] imx: mx6sx: Fix issue in LCDIF clock enablement
Date: Tue, 2 Feb 2016 21:25:26 +0100	[thread overview]
Message-ID: <56B110B6.2020106@denx.de> (raw)
In-Reply-To: <1453816918-25383-1-git-send-email-ye.li@nxp.com>



On 26/01/2016 15:01, Ye Li wrote:
> Wrong checking for the base_addr paramter with LCDIF1 and LCDIF2. Always
> enter the -EINVAL return.
> 
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
>  arch/arm/cpu/armv7/mx6/clock.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
> index 27a3f2f..007204d 100644
> --- a/arch/arm/cpu/armv7/mx6/clock.c
> +++ b/arch/arm/cpu/armv7/mx6/clock.c
> @@ -742,8 +742,8 @@ int enable_lcdif_clock(u32 base_addr)
>  	u32 lcdif_clk_sel_mask, lcdif_ccgr3_mask;
>  
>  	if (is_cpu_type(MXC_CPU_MX6SX)) {
> -		if ((base_addr == LCDIF1_BASE_ADDR) ||
> -		    (base_addr == LCDIF2_BASE_ADDR)) {
> +		if ((base_addr != LCDIF1_BASE_ADDR) &&
> +		    (base_addr != LCDIF2_BASE_ADDR)) {
>  			puts("Wrong LCD interface!\n");
>  			return -EINVAL;
>  		}
> 
Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2016-02-02 20:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 14:01 [U-Boot] [PATCH 1/2] imx: mx6sx: Fix issue in LCDIF clock enablement Ye Li
2016-01-26 14:01 ` [U-Boot] [PATCH 2/2] imx: mx6ul/sx: Fix issue in LCDIF clock dividers calculation Ye Li
2016-01-26 14:12   ` Stefano Babic
2016-02-02 20:26   ` Stefano Babic
2016-01-26 14:11 ` [U-Boot] [PATCH 1/2] imx: mx6sx: Fix issue in LCDIF clock enablement Stefano Babic
2016-02-02 20:25 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B110B6.2020106@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox