From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Thu, 4 Feb 2016 12:34:57 +0100 Subject: [U-Boot] [PATCH] usb: gadget: f_thor: free the allocated out request buffer In-Reply-To: <32c1313a080a206a70a57455794ec2116906902f.1449489553.git.michal.simek@xilinx.com> References: <32c1313a080a206a70a57455794ec2116906902f.1449489553.git.michal.simek@xilinx.com> Message-ID: <56B33761.9070200@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi guys, On 7.12.2015 12:59, Michal Simek wrote: > From: Siva Durga Prasad Paladugu > > Fix the memory leak by freeing the allocated out request buffer > > Signed-off-by: Siva Durga Prasad Paladugu > Signed-off-by: Michal Simek > --- > > drivers/usb/gadget/f_thor.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c > index a60e9487e774..75b72902c9d5 100644 > --- a/drivers/usb/gadget/f_thor.c > +++ b/drivers/usb/gadget/f_thor.c > @@ -51,6 +51,7 @@ DEFINE_CACHE_ALIGN_BUFFER(unsigned char, thor_rx_data_buf, > DEFINE_CACHE_ALIGN_BUFFER(char, f_name, F_NAME_BUF_SIZE); > static unsigned long long int thor_file_size; > static int alt_setting_num; > +static void *out_req_buf; > > static void send_rsp(const struct rsp_box *rsp) > { > @@ -891,6 +892,8 @@ static void thor_func_disable(struct usb_function *f) > } > > if (dev->out_ep->driver_data) { > + if (out_req_buf) > + free(out_req_buf); > dev->out_req->buf = NULL; > usb_ep_free_request(dev->out_ep, dev->out_req); > usb_ep_disable(dev->out_ep); > @@ -947,6 +950,7 @@ static int thor_eps_setup(struct usb_function *f) > } > > dev->out_req = req; > + out_req_buf = dev->out_req->buf; > /* ACM control EP */ > ep = dev->int_ep; > ep->driver_data = cdev; /* claim */ > any update on this one? Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: OpenPGP digital signature URL: