* [U-Boot] help on using patman
@ 2016-02-04 15:09 Mugunthan V N
2016-02-04 15:51 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Mugunthan V N @ 2016-02-04 15:09 UTC (permalink / raw)
To: u-boot
Hi Simon
I tried to use patman with a sample commit, below is the commit
with the tag patmantest
Commit:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ git show patmantest
tag patmantest
Tagger: Mugunthan V N <mugunthanvnm@ti.com>
Date: Thu Feb 4 11:51:48 2016 +0530
Series-to: me
Series-prefix: RFC
Cover-letter:
Unified command execution in one place
At present two parsers have similar code to execute commands. Also
cmd_usage() is called all over the place. This series adds a single
function which processes commands called cmd_process().
END
commit 02c23a9b585d91272befb8fe43d21fe52e1fd139
Author: Mugunthan V N <mugunthanvnm@ti.com>
Date: Mon Jan 18 14:17:43 2016 +0530
defconfig: dra72_evm: enable disk driver model
Enable disk driver model for dra72_evm as dwc_ahci supports
driver model
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
diff --git a/configs/dra72_evm_defconfig b/configs/dra72_evm_defconfig
index 32d1dc1..7ff2a4e 100644
--- a/configs/dra72_evm_defconfig
+++ b/configs/dra72_evm_defconfig
@@ -24,3 +24,5 @@ CONFIG_DM_SPI=y
CONFIG_DM_SPI_FLASH=y
CONFIG_TIMER=y
CONFIG_OMAP_TIMER=y
+CONFIG_DISK=y
+CONFIG_DWC_AHCI=y
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
But when I patman -n, it throws below error
$ ./tools/patman/patman -n
Cleaned 1 patches
total: 0 errors, 0 warnings, 0 checks, 5 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
Traceback (most recent call last):
File "./tools/patman/patman", line 158, in <module>
options.add_maintainers)
File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/series.py", line 222, in MakeCcFile
raise_on_error=raise_on_error)
File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 321, in BuildEmailList
raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 495, in LookupEmail
raise ValueError, msg
ValueError: Alias 'defconfig' not found
Then I tried with patman setting ignore_errors: True and
process_tags: False, then the out seems fine but the tag
is not processed. Do you find any thing I missed?
Output with modified patman settings:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ ./tools/patman/patman -n
Cleaned 1 patches
total: 0 errors, 0 warnings, 0 checks, 5 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
No recipient.
Please add something like this to a commit
Series-to: Fred Bloggs <f.blogs@napier.co.nz>
Or do something like this
git config sendemail.to u-boot at lists.denx.de
Dry run, so not doing much. But I would do this:
Send a total of 1 patch with no cover letter.
0001-defconfig-dra72_evm-enable-disk-driver-model.patch
Cc: u-boot at lists.denx.de
Cc: Lokesh Vutla <lokeshvutla@ti.com>
Version: None
Prefix: None
Here is my patman config
$ cat ~/.patman
[alias]
me: Mugunthan V N <mugunthanvnm@ti.com>
[settings]
ignore_errors: True
process_tags: False
verbose: True
Regards
Mugunthan V N
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] help on using patman
2016-02-04 15:09 [U-Boot] help on using patman Mugunthan V N
@ 2016-02-04 15:51 ` Simon Glass
2016-02-05 6:24 ` Mugunthan V N
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2016-02-04 15:51 UTC (permalink / raw)
To: u-boot
Hi Mugunthan,
On 4 February 2016 at 08:09, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> Hi Simon
>
> I tried to use patman with a sample commit, below is the commit
> with the tag patmantest
>
> Commit:
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> $ git show patmantest
> tag patmantest
> Tagger: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Thu Feb 4 11:51:48 2016 +0530
>
> Series-to: me
> Series-prefix: RFC
> Cover-letter:
> Unified command execution in one place
>
> At present two parsers have similar code to execute commands. Also
> cmd_usage() is called all over the place. This series adds a single
> function which processes commands called cmd_process().
> END
>
> commit 02c23a9b585d91272befb8fe43d21fe52e1fd139
> Author: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Mon Jan 18 14:17:43 2016 +0530
>
> defconfig: dra72_evm: enable disk driver model
>
> Enable disk driver model for dra72_evm as dwc_ahci supports
> driver model
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> diff --git a/configs/dra72_evm_defconfig b/configs/dra72_evm_defconfig
> index 32d1dc1..7ff2a4e 100644
> --- a/configs/dra72_evm_defconfig
> +++ b/configs/dra72_evm_defconfig
> @@ -24,3 +24,5 @@ CONFIG_DM_SPI=y
> CONFIG_DM_SPI_FLASH=y
> CONFIG_TIMER=y
> CONFIG_OMAP_TIMER=y
> +CONFIG_DISK=y
> +CONFIG_DWC_AHCI=y
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> But when I patman -n, it throws below error
>
> $ ./tools/patman/patman -n
> Cleaned 1 patches
> total: 0 errors, 0 warnings, 0 checks, 5 lines checked
>
> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
I'm not sure where this message comes from - I don't see it. I suppose
it is checkpatch.pl.
>
> 0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
> Traceback (most recent call last):
> File "./tools/patman/patman", line 158, in <module>
> options.add_maintainers)
> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/series.py", line 222, in MakeCcFile
> raise_on_error=raise_on_error)
> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 321, in BuildEmailList
> raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 495, in LookupEmail
> raise ValueError, msg
> ValueError: Alias 'defconfig' not found
This means it couldn't find the alias 'defconfig' :-)
You have a defconfig: tag in your subject so patman will Cc that
alias. Since it doesn't exist you get an error. You can use the -t
option to ignore bad takes, or add an alias to .patman, like this:
defconfig: Fred Bloggs <f.bloggs@napier.co.nz>
Also see 'Where Patches Are Sent' in the README.
>
>
> Then I tried with patman setting ignore_errors: True and
> process_tags: False, then the out seems fine but the tag
> is not processed. Do you find any thing I missed?
Well only that you told it not to process the tag. I don't think it's
a good idea to add those settings.
Try 'patman -nt' to use tags if they can be found, and ignore tags
that can't be found.
>
> Output with modified patman settings:
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> $ ./tools/patman/patman -n
> Cleaned 1 patches
> total: 0 errors, 0 warnings, 0 checks, 5 lines checked
>
> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
>
> 0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
> No recipient.
> Please add something like this to a commit
> Series-to: Fred Bloggs <f.blogs@napier.co.nz>
> Or do something like this
> git config sendemail.to u-boot at lists.denx.de
> Dry run, so not doing much. But I would do this:
>
> Send a total of 1 patch with no cover letter.
> 0001-defconfig-dra72_evm-enable-disk-driver-model.patch
> Cc: u-boot at lists.denx.de
> Cc: Lokesh Vutla <lokeshvutla@ti.com>
>
> Version: None
> Prefix: None
>
> Here is my patman config
> $ cat ~/.patman
> [alias]
> me: Mugunthan V N <mugunthanvnm@ti.com>
>
> [settings]
> ignore_errors: True
> process_tags: False
> verbose: True
>
> Regards
> Mugunthan V N
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] help on using patman
2016-02-04 15:51 ` Simon Glass
@ 2016-02-05 6:24 ` Mugunthan V N
2016-02-06 20:44 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Mugunthan V N @ 2016-02-05 6:24 UTC (permalink / raw)
To: u-boot
Hi Simon
On Thursday 04 February 2016 09:21 PM, Simon Glass wrote:
> Hi Mugunthan,
>
> On 4 February 2016 at 08:09, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>> Hi Simon
>>
>> I tried to use patman with a sample commit, below is the commit
>> with the tag patmantest
>>
>> Commit:
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> $ git show patmantest
>> tag patmantest
>> Tagger: Mugunthan V N <mugunthanvnm@ti.com>
>> Date: Thu Feb 4 11:51:48 2016 +0530
>>
>> Series-to: me
>> Series-prefix: RFC
>> Cover-letter:
>> Unified command execution in one place
>>
>> At present two parsers have similar code to execute commands. Also
>> cmd_usage() is called all over the place. This series adds a single
>> function which processes commands called cmd_process().
>> END
>>
>> commit 02c23a9b585d91272befb8fe43d21fe52e1fd139
>> Author: Mugunthan V N <mugunthanvnm@ti.com>
>> Date: Mon Jan 18 14:17:43 2016 +0530
>>
>> defconfig: dra72_evm: enable disk driver model
>>
>> Enable disk driver model for dra72_evm as dwc_ahci supports
>> driver model
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>
>> diff --git a/configs/dra72_evm_defconfig b/configs/dra72_evm_defconfig
>> index 32d1dc1..7ff2a4e 100644
>> --- a/configs/dra72_evm_defconfig
>> +++ b/configs/dra72_evm_defconfig
>> @@ -24,3 +24,5 @@ CONFIG_DM_SPI=y
>> CONFIG_DM_SPI_FLASH=y
>> CONFIG_TIMER=y
>> CONFIG_OMAP_TIMER=y
>> +CONFIG_DISK=y
>> +CONFIG_DWC_AHCI=y
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> But when I patman -n, it throws below error
>>
>> $ ./tools/patman/patman -n
>> Cleaned 1 patches
>> total: 0 errors, 0 warnings, 0 checks, 5 lines checked
>>
>> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
>
> I'm not sure where this message comes from - I don't see it. I suppose
> it is checkpatch.pl.
Yep this is from checkpatch.pl
>
>>
>> 0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
>> Traceback (most recent call last):
>> File "./tools/patman/patman", line 158, in <module>
>> options.add_maintainers)
>> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/series.py", line 222, in MakeCcFile
>> raise_on_error=raise_on_error)
>> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 321, in BuildEmailList
>> raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
>> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 495, in LookupEmail
>> raise ValueError, msg
>> ValueError: Alias 'defconfig' not found
>
> This means it couldn't find the alias 'defconfig' :-)
>
> You have a defconfig: tag in your subject so patman will Cc that
> alias. Since it doesn't exist you get an error. You can use the -t
> option to ignore bad takes, or add an alias to .patman, like this:
>
> defconfig: Fred Bloggs <f.bloggs@napier.co.nz>
>
> Also see 'Where Patches Are Sent' in the README.
Hmmm, I was basically misunderstood that I need to add patman notes in a
tag, but it has to be present in commit message itself wright.
Then when you want to publish your branch with logs, its not possible as
to remove patman notes from commit in this process commit ids will change.
>
>>
>>
>> Then I tried with patman setting ignore_errors: True and
>> process_tags: False, then the out seems fine but the tag
>> is not processed. Do you find any thing I missed?
>
> Well only that you told it not to process the tag. I don't think it's
> a good idea to add those settings.
>
> Try 'patman -nt' to use tags if they can be found, and ignore tags
> that can't be found.
Thanks, Now it worked for me.
Regards
Mugunthan V N
>
>>
>> Output with modified patman settings:
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> $ ./tools/patman/patman -n
>> Cleaned 1 patches
>> total: 0 errors, 0 warnings, 0 checks, 5 lines checked
>>
>> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
>>
>> 0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
>> No recipient.
>> Please add something like this to a commit
>> Series-to: Fred Bloggs <f.blogs@napier.co.nz>
>> Or do something like this
>> git config sendemail.to u-boot at lists.denx.de
>> Dry run, so not doing much. But I would do this:
>>
>> Send a total of 1 patch with no cover letter.
>> 0001-defconfig-dra72_evm-enable-disk-driver-model.patch
>> Cc: u-boot at lists.denx.de
>> Cc: Lokesh Vutla <lokeshvutla@ti.com>
>>
>> Version: None
>> Prefix: None
>>
>> Here is my patman config
>> $ cat ~/.patman
>> [alias]
>> me: Mugunthan V N <mugunthanvnm@ti.com>
>>
>> [settings]
>> ignore_errors: True
>> process_tags: False
>> verbose: True
>>
>> Regards
>> Mugunthan V N
>
> Regards,
> Simon
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] help on using patman
2016-02-05 6:24 ` Mugunthan V N
@ 2016-02-06 20:44 ` Simon Glass
0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2016-02-06 20:44 UTC (permalink / raw)
To: u-boot
Hi Mugunthan,
On 4 February 2016 at 23:24, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> Hi Simon
>
> On Thursday 04 February 2016 09:21 PM, Simon Glass wrote:
>> Hi Mugunthan,
>>
>> On 4 February 2016 at 08:09, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>>> Hi Simon
>>>
>>> I tried to use patman with a sample commit, below is the commit
>>> with the tag patmantest
>>>
>>> Commit:
>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> $ git show patmantest
>>> tag patmantest
>>> Tagger: Mugunthan V N <mugunthanvnm@ti.com>
>>> Date: Thu Feb 4 11:51:48 2016 +0530
>>>
>>> Series-to: me
>>> Series-prefix: RFC
>>> Cover-letter:
>>> Unified command execution in one place
>>>
>>> At present two parsers have similar code to execute commands. Also
>>> cmd_usage() is called all over the place. This series adds a single
>>> function which processes commands called cmd_process().
>>> END
>>>
>>> commit 02c23a9b585d91272befb8fe43d21fe52e1fd139
>>> Author: Mugunthan V N <mugunthanvnm@ti.com>
>>> Date: Mon Jan 18 14:17:43 2016 +0530
>>>
>>> defconfig: dra72_evm: enable disk driver model
>>>
>>> Enable disk driver model for dra72_evm as dwc_ahci supports
>>> driver model
>>>
>>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>>
>>> diff --git a/configs/dra72_evm_defconfig b/configs/dra72_evm_defconfig
>>> index 32d1dc1..7ff2a4e 100644
>>> --- a/configs/dra72_evm_defconfig
>>> +++ b/configs/dra72_evm_defconfig
>>> @@ -24,3 +24,5 @@ CONFIG_DM_SPI=y
>>> CONFIG_DM_SPI_FLASH=y
>>> CONFIG_TIMER=y
>>> CONFIG_OMAP_TIMER=y
>>> +CONFIG_DISK=y
>>> +CONFIG_DWC_AHCI=y
>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> But when I patman -n, it throws below error
>>>
>>> $ ./tools/patman/patman -n
>>> Cleaned 1 patches
>>> total: 0 errors, 0 warnings, 0 checks, 5 lines checked
>>>
>>> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
>>
>> I'm not sure where this message comes from - I don't see it. I suppose
>> it is checkpatch.pl.
>
> Yep this is from checkpatch.pl
>
>>
>>>
>>> 0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
>>> Traceback (most recent call last):
>>> File "./tools/patman/patman", line 158, in <module>
>>> options.add_maintainers)
>>> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/series.py", line 222, in MakeCcFile
>>> raise_on_error=raise_on_error)
>>> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 321, in BuildEmailList
>>> raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
>>> File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 495, in LookupEmail
>>> raise ValueError, msg
>>> ValueError: Alias 'defconfig' not found
>>
>> This means it couldn't find the alias 'defconfig' :-)
>>
>> You have a defconfig: tag in your subject so patman will Cc that
>> alias. Since it doesn't exist you get an error. You can use the -t
>> option to ignore bad takes, or add an alias to .patman, like this:
>>
>> defconfig: Fred Bloggs <f.bloggs@napier.co.nz>
>>
>> Also see 'Where Patches Are Sent' in the README.
>
> Hmmm, I was basically misunderstood that I need to add patman notes in a
> tag, but it has to be present in commit message itself wright.
>
> Then when you want to publish your branch with logs, its not possible as
> to remove patman notes from commit in this process commit ids will change.
That's right. I don't see a lot of benefit in removing the notes.
>
>>
>>>
>>>
>>> Then I tried with patman setting ignore_errors: True and
>>> process_tags: False, then the out seems fine but the tag
>>> is not processed. Do you find any thing I missed?
>>
>> Well only that you told it not to process the tag. I don't think it's
>> a good idea to add those settings.
>>
>> Try 'patman -nt' to use tags if they can be found, and ignore tags
>> that can't be found.
>
> Thanks, Now it worked for me.
OK good.
[snip]
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-06 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-04 15:09 [U-Boot] help on using patman Mugunthan V N
2016-02-04 15:51 ` Simon Glass
2016-02-05 6:24 ` Mugunthan V N
2016-02-06 20:44 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox