* [U-Boot] Converting serial_s3c24x0.c to driver model
@ 2016-01-31 16:16 Simon Glass
2016-02-02 15:59 ` David Müller (ELSOFT AG)
2016-02-05 10:59 ` [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use? David Müller (ELSOFT AG)
0 siblings, 2 replies; 6+ messages in thread
From: Simon Glass @ 2016-01-31 16:16 UTC (permalink / raw)
To: u-boot
Hi David,
I'm sorry if you have not heard about this before. I sent out an email
to all maintainers some months ago.
You are listed as the maintainer of a few boards which use the
serial_s3c24x0.c serial driver. We are trying to convert all of these
drivers to driver model. Please see doc/driver-model/serial-howto.txt.
Do you have an update please?
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Converting serial_s3c24x0.c to driver model
2016-01-31 16:16 [U-Boot] Converting serial_s3c24x0.c to driver model Simon Glass
@ 2016-02-02 15:59 ` David Müller (ELSOFT AG)
2016-02-02 16:21 ` Simon Glass
2016-02-05 10:59 ` [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use? David Müller (ELSOFT AG)
1 sibling, 1 reply; 6+ messages in thread
From: David Müller (ELSOFT AG) @ 2016-02-02 15:59 UTC (permalink / raw)
To: u-boot
Hello
Simon Glass wrote:
> I'm sorry if you have not heard about this before. I sent out an email
> to all maintainers some months ago.
> You are listed as the maintainer of a few boards which use the
> serial_s3c24x0.c serial driver. We are trying to convert all of these
> drivers to driver model. Please see doc/driver-model/serial-howto.txt.
>
> Do you have an update please?
Sorry, seems that I missed your previous message somehow.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] Converting serial_s3c24x0.c to driver model
2016-02-02 15:59 ` David Müller (ELSOFT AG)
@ 2016-02-02 16:21 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2016-02-02 16:21 UTC (permalink / raw)
To: u-boot
Hi David,
On 2 February 2016 at 08:59, David M?ller (ELSOFT AG)
<d.mueller@elsoft.ch> wrote:
> Hello
>
> Simon Glass wrote:
>> I'm sorry if you have not heard about this before. I sent out an email
>> to all maintainers some months ago.
>> You are listed as the maintainer of a few boards which use the
>> serial_s3c24x0.c serial driver. We are trying to convert all of these
>> drivers to driver model. Please see doc/driver-model/serial-howto.txt.
>>
>> Do you have an update please?
>
> Sorry, seems that I missed your previous message somehow.
I'm sorry about that. - it was a cc to you in November. Are you
planning to take a look at this?
Regards,
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use?
2016-01-31 16:16 [U-Boot] Converting serial_s3c24x0.c to driver model Simon Glass
2016-02-02 15:59 ` David Müller (ELSOFT AG)
@ 2016-02-05 10:59 ` David Müller (ELSOFT AG)
2016-02-05 15:33 ` Tom Rini
2016-02-05 19:31 ` Wolfgang Denk
1 sibling, 2 replies; 6+ messages in thread
From: David Müller (ELSOFT AG) @ 2016-02-05 10:59 UTC (permalink / raw)
To: u-boot
Hello
While trying to convert the serial_s3c24x0.c driver to DM, I noticed
that no offical U-Boot configuration seems to be using the
CONFIG_MODEM_SUPPORT or CONFIG_HWFLOW option.
Do you know if these two options are still in use somewhere else? Or can
all the references to these options be removed irrevocably?
> git grep CONFIG_MODEM_SUPPORT | uniq
README: CONFIG_MODEM_SUPPORT
arch/powerpc/cpu/mpc8xx/serial.c:#ifdef CONFIG_MODEM_SUPPORT
common/Makefile:obj-$(CONFIG_MODEM_SUPPORT) += modem.o
common/board_f.c:#ifdef CONFIG_MODEM_SUPPORT
common/main.c:#ifdef CONFIG_MODEM_SUPPORT
drivers/serial/serial_s3c24x0.c:#ifdef CONFIG_MODEM_SUPPORT
include/asm-generic/global_data.h:#ifdef CONFIG_MODEM_SUPPORT
> git grep CONFIG_HWFLOW | uniq
README: CONFIG_HWFLOW
common/modem.c:#ifdef CONFIG_HWFLOW
doc/README.Modem:UART driver supports it (see CONFIG_HWFLOW compile-time
flag in
drivers/serial/serial_imx.c:#ifdef CONFIG_HWFLOW
drivers/serial/serial_s3c24x0.c:#ifdef CONFIG_HWFLOW
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use?
2016-02-05 10:59 ` [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use? David Müller (ELSOFT AG)
@ 2016-02-05 15:33 ` Tom Rini
2016-02-05 19:31 ` Wolfgang Denk
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2016-02-05 15:33 UTC (permalink / raw)
To: u-boot
On Fri, Feb 05, 2016 at 11:59:17AM +0100, David M?ller (ELSOFT AG) wrote:
> Hello
>
> While trying to convert the serial_s3c24x0.c driver to DM, I noticed
> that no offical U-Boot configuration seems to be using the
> CONFIG_MODEM_SUPPORT or CONFIG_HWFLOW option.
>
> Do you know if these two options are still in use somewhere else? Or can
> all the references to these options be removed irrevocably?
I think all boards have been removed so yes, go ahead and drop the code
as a pre-req patch to the DM work you're doing, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160205/72b88327/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use?
2016-02-05 10:59 ` [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use? David Müller (ELSOFT AG)
2016-02-05 15:33 ` Tom Rini
@ 2016-02-05 19:31 ` Wolfgang Denk
1 sibling, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2016-02-05 19:31 UTC (permalink / raw)
To: u-boot
Dear David,
In message <56B48085.2050500@elsoft.ch> you wrote:
>
> While trying to convert the serial_s3c24x0.c driver to DM, I noticed
> that no offical U-Boot configuration seems to be using the
> CONFIG_MODEM_SUPPORT or CONFIG_HWFLOW option.
>
> Do you know if these two options are still in use somewhere else? Or can
> all the references to these options be removed irrevocably?
IIRC the modem support was added more than a decade ago for a specific
board which has been removed from the tree long ago. I cannot
remember that any other user has questions or problems with that code,
so probably nobody else ever used it.
I think chances are good that you can remove this stuff and nobody
would ever notice ;-)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am a computer. I am dumber than any human and smarter than any ad-
ministrator.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-05 19:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-31 16:16 [U-Boot] Converting serial_s3c24x0.c to driver model Simon Glass
2016-02-02 15:59 ` David Müller (ELSOFT AG)
2016-02-02 16:21 ` Simon Glass
2016-02-05 10:59 ` [U-Boot] CONFIG_MODEM_SUPPORT / CONFIG_HWFLOW still in use? David Müller (ELSOFT AG)
2016-02-05 15:33 ` Tom Rini
2016-02-05 19:31 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox