public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] dm: video: Add a temporary work-around for old stdout var
Date: Mon, 8 Feb 2016 14:09:06 -0700	[thread overview]
Message-ID: <56B903F2.8090602@wwwdotorg.org> (raw)
In-Reply-To: <1454794298-20111-1-git-send-email-sjg@chromium.org>

On 02/06/2016 02:31 PM, Simon Glass wrote:
> Boards with a saved environment may use 'lcd' in their stdout environment
> variable, expecting that this will enable output to the LCD. When the board
> moves to use driver model for video, this will no-longer work. Add a
> work-around to fix this. A warning messages is printed, and we will remove
> the work-around at the end of 2016.

I tested u-boot-dm/tegra-working which I assume is the same as these 
patches, so the series,

Tested-by: Stephen Warren <swarren@nvidia.com>

But...

> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig

> +config VIDCONSOLE_AS_LCD
> +	bool "Use 'vidconsole' when 'lcd' is seen in stdout"
> +	depends on DM_VIDEO
> +	help
> +	  This is a work-around for boards which have 'lcd' in their stdout
> +	  environment variable, but have moved to use driver model for video.
> +	  In this case the console will no-longer work. While it is possible
> +	  to update the environment, the breakage may be confusing for users.
> +	  This option will be removed around the end of 2016.

Removing this option at the end of 2016 is simply going to cause the 
exact same problem then. Is there any harm in simply not deprecating 
this feature? I suppose at least there's a warning that people should 
convert over, so perhaps they will and so the chances of people getting 
bitten by this well be less by then.

  parent reply	other threads:[~2016-02-08 21:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-06 21:31 [U-Boot] [PATCH 1/2] dm: video: Add a temporary work-around for old stdout var Simon Glass
2016-02-06 21:31 ` [U-Boot] [PATCH 2/2] video: tegra: Enable the 'lcd' env variable work-around Simon Glass
2016-02-06 22:23   ` Anatolij Gustschin
2016-02-11 20:40   ` Anatolij Gustschin
2016-02-06 22:23 ` [U-Boot] [PATCH 1/2] dm: video: Add a temporary work-around for old stdout var Anatolij Gustschin
2016-02-08 21:09 ` Stephen Warren [this message]
2016-02-11 20:28   ` Simon Glass
2016-02-11 20:38 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B903F2.8090602@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox