From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: show error message when "mmc dev" command fails
Date: Wed, 10 Feb 2016 09:27:36 -0700 [thread overview]
Message-ID: <56BB64F8.4000706@wwwdotorg.org> (raw)
In-Reply-To: <1455108396-31937-1-git-send-email-yamada.masahiro@socionext.com>
On 02/10/2016 05:46 AM, Masahiro Yamada wrote:
> Currently, "mmc dev" can silently fail. In case of failure, tell
> the user about it.
Does it make sense to print this error inside init_mmc_device() instead,
so that we don't have to add printf()s to all call sites?
I'm not sure the answer to my question is yes; just something to ponder.
Also note that one disadvantage of printing error messages all the time
is that the distro boot scripts (by default) attempt to probe all
defined storage devices, so printing errors will make that noisy.
Perhaps that should be solved by adding a -q option (for "quiet") so
those scripts can be non-noisy?
next prev parent reply other threads:[~2016-02-10 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 12:46 [U-Boot] [PATCH] mmc: show error message when "mmc dev" command fails Masahiro Yamada
2016-02-10 12:49 ` Stefan Roese
2016-02-10 16:27 ` Stephen Warren [this message]
2016-02-12 14:55 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB64F8.4000706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox