From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 10 Feb 2016 09:27:36 -0700
Subject: [U-Boot] [PATCH] mmc: show error message when "mmc dev" command
 fails
In-Reply-To: <1455108396-31937-1-git-send-email-yamada.masahiro@socionext.com>
References: <1455108396-31937-1-git-send-email-yamada.masahiro@socionext.com>
Message-ID: <56BB64F8.4000706@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/10/2016 05:46 AM, Masahiro Yamada wrote:
> Currently, "mmc dev" can silently fail.  In case of failure, tell
> the user about it.

Does it make sense to print this error inside init_mmc_device() instead, 
so that we don't have to add printf()s to all call sites?

I'm not sure the answer to my question is yes; just something to ponder.

Also note that one disadvantage of printing error messages all the time 
is that the distro boot scripts (by default) attempt to probe all 
defined storage devices, so printing errors will make that noisy. 
Perhaps that should be solved by adding a -q option (for "quiet") so 
those scripts can be non-noisy?