* [U-Boot] [PATCH] exynos: Set CNTFRQ
@ 2016-02-01 20:41 Alexander Graf
2016-02-02 0:05 ` Simon Glass
2016-02-11 2:17 ` Minkyu Kang
0 siblings, 2 replies; 7+ messages in thread
From: Alexander Graf @ 2016-02-01 20:41 UTC (permalink / raw)
To: u-boot
Commit 73a1cb27 moved the check whether we should set the architected
timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but
did not update all users of it.
The one where I (finally) realized why KVM didn't work is the Arndale
board, so this patch adds the respective define to it.
Signed-off-by: Alexander Graf <agraf@suse.de>
Fixes: 73a1cb27
---
include/configs/exynos-common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
index 852829c..c4e731f 100644
--- a/include/configs/exynos-common.h
+++ b/include/configs/exynos-common.h
@@ -31,6 +31,7 @@
/* input clock of PLL: 24MHz input clock */
#define CONFIG_SYS_CLK_FREQ 24000000
+#define CONFIG_TIMER_CLK_FREQ 24000000
#define CONFIG_SETUP_MEMORY_TAGS
#define CONFIG_CMDLINE_TAG
--
2.6.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] exynos: Set CNTFRQ
2016-02-01 20:41 [U-Boot] [PATCH] exynos: Set CNTFRQ Alexander Graf
@ 2016-02-02 0:05 ` Simon Glass
2016-02-11 2:17 ` Minkyu Kang
1 sibling, 0 replies; 7+ messages in thread
From: Simon Glass @ 2016-02-02 0:05 UTC (permalink / raw)
To: u-boot
+Minkyu
On 1 February 2016 at 13:41, Alexander Graf <agraf@suse.de> wrote:
> Commit 73a1cb27 moved the check whether we should set the architected
> timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but
> did not update all users of it.
>
> The one where I (finally) realized why KVM didn't work is the Arndale
> board, so this patch adds the respective define to it.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> Fixes: 73a1cb27
> ---
> include/configs/exynos-common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
> index 852829c..c4e731f 100644
> --- a/include/configs/exynos-common.h
> +++ b/include/configs/exynos-common.h
> @@ -31,6 +31,7 @@
>
> /* input clock of PLL: 24MHz input clock */
> #define CONFIG_SYS_CLK_FREQ 24000000
> +#define CONFIG_TIMER_CLK_FREQ 24000000
>
> #define CONFIG_SETUP_MEMORY_TAGS
> #define CONFIG_CMDLINE_TAG
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] exynos: Set CNTFRQ
2016-02-01 20:41 [U-Boot] [PATCH] exynos: Set CNTFRQ Alexander Graf
2016-02-02 0:05 ` Simon Glass
@ 2016-02-11 2:17 ` Minkyu Kang
2016-03-10 13:18 ` [U-Boot] [PATCH v2] " Alexander Graf
1 sibling, 1 reply; 7+ messages in thread
From: Minkyu Kang @ 2016-02-11 2:17 UTC (permalink / raw)
To: u-boot
Dear Alexander Graf,
On 02/02/16 05:41, Alexander Graf wrote:
> Commit 73a1cb27 moved the check whether we should set the architected
> timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but
> did not update all users of it.
>
> The one where I (finally) realized why KVM didn't work is the Arndale
> board, so this patch adds the respective define to it.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> Fixes: 73a1cb27
> ---
> include/configs/exynos-common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
> index 852829c..c4e731f 100644
> --- a/include/configs/exynos-common.h
> +++ b/include/configs/exynos-common.h
> @@ -31,6 +31,7 @@
>
> /* input clock of PLL: 24MHz input clock */
> #define CONFIG_SYS_CLK_FREQ 24000000
> +#define CONFIG_TIMER_CLK_FREQ 24000000
patch looks good but,
Please make sure that it doesn't have a different value with system clock, always. (If you expected it)
#define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ
>
> #define CONFIG_SETUP_MEMORY_TAGS
> #define CONFIG_CMDLINE_TAG
>
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] exynos: Set CNTFRQ
2016-02-11 2:17 ` Minkyu Kang
@ 2016-03-10 13:18 ` Alexander Graf
2016-03-10 16:33 ` york sun
2016-03-10 16:35 ` york sun
0 siblings, 2 replies; 7+ messages in thread
From: Alexander Graf @ 2016-03-10 13:18 UTC (permalink / raw)
To: u-boot
Commit 73a1cb27 moved the check whether we should set the architected
timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but
did not update all users of it.
The one where I (finally) realized why KVM didn't work is the Arndale
board, so this patch adds the respective define to it.
Signed-off-by: Alexander Graf <agraf@suse.de>
Fixes: 73a1cb27
---
v1 -> v2:
- Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number
---
include/configs/exynos-common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
index 852829c..b61f889 100644
--- a/include/configs/exynos-common.h
+++ b/include/configs/exynos-common.h
@@ -31,6 +31,7 @@
/* input clock of PLL: 24MHz input clock */
#define CONFIG_SYS_CLK_FREQ 24000000
+#define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ
#define CONFIG_SETUP_MEMORY_TAGS
#define CONFIG_CMDLINE_TAG
--
1.8.5.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] exynos: Set CNTFRQ
2016-03-10 13:18 ` [U-Boot] [PATCH v2] " Alexander Graf
@ 2016-03-10 16:33 ` york sun
2016-03-10 16:35 ` york sun
1 sibling, 0 replies; 7+ messages in thread
From: york sun @ 2016-03-10 16:33 UTC (permalink / raw)
To: u-boot
On 03/10/2016 05:18 AM, Alexander Graf wrote:
> Commit 73a1cb27 moved the check whether we should set the architected
> timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but
> did not update all users of it.
>
> The one where I (finally) realized why KVM didn't work is the Arndale
> board, so this patch adds the respective define to it.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> Fixes: 73a1cb27
>
> ---
>
> v1 -> v2:
>
> - Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number
> ---
> include/configs/exynos-common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
> index 852829c..b61f889 100644
> --- a/include/configs/exynos-common.h
> +++ b/include/configs/exynos-common.h
> @@ -31,6 +31,7 @@
>
> /* input clock of PLL: 24MHz input clock */
> #define CONFIG_SYS_CLK_FREQ 24000000
> +#define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ
>
> #define CONFIG_SETUP_MEMORY_TAGS
> #define CONFIG_CMDLINE_TAG
>
This makes sense.
Xiubo,
Can you take another look to make sure nothing else is missed?
York
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] exynos: Set CNTFRQ
2016-03-10 13:18 ` [U-Boot] [PATCH v2] " Alexander Graf
2016-03-10 16:33 ` york sun
@ 2016-03-10 16:35 ` york sun
2016-04-14 10:41 ` Minkyu Kang
1 sibling, 1 reply; 7+ messages in thread
From: york sun @ 2016-03-10 16:35 UTC (permalink / raw)
To: u-boot
On 03/10/2016 05:18 AM, Alexander Graf wrote:
> Commit 73a1cb27 moved the check whether we should set the architected
> timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but
> did not update all users of it.
>
> The one where I (finally) realized why KVM didn't work is the Arndale
> board, so this patch adds the respective define to it.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> Fixes: 73a1cb27
>
> ---
>
> v1 -> v2:
>
> - Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number
> ---
> include/configs/exynos-common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
> index 852829c..b61f889 100644
> --- a/include/configs/exynos-common.h
> +++ b/include/configs/exynos-common.h
> @@ -31,6 +31,7 @@
>
> /* input clock of PLL: 24MHz input clock */
> #define CONFIG_SYS_CLK_FREQ 24000000
> +#define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ
>
> #define CONFIG_SETUP_MEMORY_TAGS
> #define CONFIG_CMDLINE_TAG
>
Reviewed-by: York Sun <york.sun@nxp.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH v2] exynos: Set CNTFRQ
2016-03-10 16:35 ` york sun
@ 2016-04-14 10:41 ` Minkyu Kang
0 siblings, 0 replies; 7+ messages in thread
From: Minkyu Kang @ 2016-04-14 10:41 UTC (permalink / raw)
To: u-boot
On 11/03/16 01:35, york sun wrote:
> On 03/10/2016 05:18 AM, Alexander Graf wrote:
>> Commit 73a1cb27 moved the check whether we should set the architected
>> timer frequency from CONFIG_SYS_CLK_FREQ to CONFIG_TIMER_CLK_FREQ, but
>> did not update all users of it.
>>
>> The one where I (finally) realized why KVM didn't work is the Arndale
>> board, so this patch adds the respective define to it.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>> Fixes: 73a1cb27
>>
>> ---
>>
>> v1 -> v2:
>>
>> - Map to CONFIG_SYS_CLK_FREQ instead of redefining to the same number
>> ---
>> include/configs/exynos-common.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
>> index 852829c..b61f889 100644
>> --- a/include/configs/exynos-common.h
>> +++ b/include/configs/exynos-common.h
>> @@ -31,6 +31,7 @@
>>
>> /* input clock of PLL: 24MHz input clock */
>> #define CONFIG_SYS_CLK_FREQ 24000000
>> +#define CONFIG_TIMER_CLK_FREQ CONFIG_SYS_CLK_FREQ
>>
>> #define CONFIG_SETUP_MEMORY_TAGS
>> #define CONFIG_CMDLINE_TAG
>>
>
> Reviewed-by: York Sun <york.sun@nxp.com>
>
>
Applied to u-boot-samsung.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-04-14 10:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 20:41 [U-Boot] [PATCH] exynos: Set CNTFRQ Alexander Graf
2016-02-02 0:05 ` Simon Glass
2016-02-11 2:17 ` Minkyu Kang
2016-03-10 13:18 ` [U-Boot] [PATCH v2] " Alexander Graf
2016-03-10 16:33 ` york sun
2016-03-10 16:35 ` york sun
2016-04-14 10:41 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox