[U-Boot] [PATCH 1/2] test/py: don't import pexpect

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

* [U-Boot] [PATCH 1/2] test/py: don't import pexpect
@ 2016-02-09  1:23 Stephen Warren
  2016-02-09  1:23 ` [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI Stephen Warren
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Stephen Warren @ 2016-02-09  1:23 UTC (permalink / raw)
  To: u-boot

From: Stephen Warren <swarren@nvidia.com>

The code replaced pexpect with custom code long ago. Don't import the
unused module so it doesn't need to be installed.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 test/py/conftest.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/py/conftest.py b/test/py/conftest.py
index 7b97cbaa0eed..1ec096e24182 100644
--- a/test/py/conftest.py
+++ b/test/py/conftest.py
@@ -17,7 +17,6 @@ import atexit
 import errno
 import os
 import os.path
-import pexpect
 import pytest
 from _pytest.runner import runtestprotocol
 import ConfigParser
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI
  2016-02-09  1:23 [U-Boot] [PATCH 1/2] test/py: don't import pexpect Stephen Warren
@ 2016-02-09  1:23 ` Stephen Warren
  2016-02-09 12:13   ` Meier, Roger
                     ` (2 more replies)
  2016-02-15  1:19 ` [U-Boot] [PATCH 1/2] test/py: don't import pexpect Simon Glass
  2016-02-15 22:36 ` [U-Boot] [U-Boot,1/2] " Tom Rini
  2 siblings, 3 replies; 8+ messages in thread
From: Stephen Warren @ 2016-02-09  1:23 UTC (permalink / raw)
  To: u-boot

From: Stephen Warren <swarren@nvidia.com>

This provides runtime test coverage in Travis, in addition to the existing
build coverage.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 .travis.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 8caaeb34553e..18bf2ed4fcdb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -16,6 +16,8 @@ addons:
     - bc
     - build-essential
     - libsdl1.2-dev
+    - python
+    - python-virtualenv
 
 cache:
  - apt
@@ -38,6 +40,9 @@ install:
  - echo -e "\n\n[toolchain-alias]\n${BUILDMAN_ALIAS} i386\n" >> ~/.buildman
  - echo -e "${BUILDMAN_ALIAS_ARM} armv5te\n" >> ~/.buildman
  - cat ~/.buildman
+ - virtualenv /tmp/venv
+ - . /tmp/venv/bin/activate
+ - pip install pytest
 
 env:
   global:
@@ -177,5 +182,8 @@ matrix:
     # some statistics about the code base
     - env:
         - TEST_CMD="sloccount ."
+    # test/py
+    - env:
+        - TEST_CMD="./test/py/test.py --bd sandbox --build"
 
 # TODO make it perfect ;-r
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI
  2016-02-09  1:23 ` [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI Stephen Warren
@ 2016-02-09 12:13   ` Meier, Roger
  2016-02-11  5:41   ` Heiko Schocher
  2016-02-15 22:36   ` [U-Boot] [U-Boot,2/2] " Tom Rini
  2 siblings, 0 replies; 8+ messages in thread
From: Meier, Roger @ 2016-02-09 12:13 UTC (permalink / raw)
  To: u-boot

Thanks Stephen

> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Dienstag, 9. Februar 2016 02:24
> To: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>; u-boot at lists.denx.de; Meier, Roger
> <r.meier@siemens.com>; Daniel Schwierzeck
> <daniel.schwierzeck@gmail.com>; Heiko Schocher <hs@denx.de>; Stephen
> Warren <swarren@nvidia.com>
> Subject: [PATCH 2/2] Enable test/py for sandbox in Travis CI
> 
> From: Stephen Warren <swarren@nvidia.com>
> 
> This provides runtime test coverage in Travis, in addition to the existing
> build coverage.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  .travis.yml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 8caaeb34553e..18bf2ed4fcdb 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -16,6 +16,8 @@ addons:
>      - bc
>      - build-essential
>      - libsdl1.2-dev
> +    - python
> +    - python-virtualenv
> 
>  cache:
>   - apt
> @@ -38,6 +40,9 @@ install:
>   - echo -e "\n\n[toolchain-alias]\n${BUILDMAN_ALIAS} i386\n" >>
> ~/.buildman
>   - echo -e "${BUILDMAN_ALIAS_ARM} armv5te\n" >> ~/.buildman
>   - cat ~/.buildman
> + - virtualenv /tmp/venv
> + - . /tmp/venv/bin/activate
> + - pip install pytest
> 
>  env:
>    global:
> @@ -177,5 +182,8 @@ matrix:
>      # some statistics about the code base
>      - env:
>          - TEST_CMD="sloccount ."
> +    # test/py
> +    - env:
> +        - TEST_CMD="./test/py/test.py --bd sandbox --build"
> 
>  # TODO make it perfect ;-r
> --
> 2.7.0

Reviewed-by: Roger Meier <r.meier@siemens.com>


Best Regards
Roger

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI
  2016-02-09  1:23 ` [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI Stephen Warren
  2016-02-09 12:13   ` Meier, Roger
@ 2016-02-11  5:41   ` Heiko Schocher
  2016-02-15  1:19     ` Simon Glass
  2016-02-15 22:36   ` [U-Boot] [U-Boot,2/2] " Tom Rini
  2 siblings, 1 reply; 8+ messages in thread
From: Heiko Schocher @ 2016-02-11  5:41 UTC (permalink / raw)
  To: u-boot

Hello Stephen,

Am 09.02.2016 um 02:23 schrieb Stephen Warren:
> From: Stephen Warren <swarren@nvidia.com>
>
> This provides runtime test coverage in Travis, in addition to the existing
> build coverage.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>   .travis.yml | 8 ++++++++
>   1 file changed, 8 insertions(+)

Very nice, thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/.travis.yml b/.travis.yml
> index 8caaeb34553e..18bf2ed4fcdb 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -16,6 +16,8 @@ addons:
>       - bc
>       - build-essential
>       - libsdl1.2-dev
> +    - python
> +    - python-virtualenv
>
>   cache:
>    - apt
> @@ -38,6 +40,9 @@ install:
>    - echo -e "\n\n[toolchain-alias]\n${BUILDMAN_ALIAS} i386\n" >> ~/.buildman
>    - echo -e "${BUILDMAN_ALIAS_ARM} armv5te\n" >> ~/.buildman
>    - cat ~/.buildman
> + - virtualenv /tmp/venv
> + - . /tmp/venv/bin/activate
> + - pip install pytest
>
>   env:
>     global:
> @@ -177,5 +182,8 @@ matrix:
>       # some statistics about the code base
>       - env:
>           - TEST_CMD="sloccount ."
> +    # test/py
> +    - env:
> +        - TEST_CMD="./test/py/test.py --bd sandbox --build"
>
>   # TODO make it perfect ;-r
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI
  2016-02-11  5:41   ` Heiko Schocher
@ 2016-02-15  1:19     ` Simon Glass
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Glass @ 2016-02-15  1:19 UTC (permalink / raw)
  To: u-boot

On 10 February 2016 at 22:41, Heiko Schocher <hs@denx.de> wrote:
> Hello Stephen,
>
> Am 09.02.2016 um 02:23 schrieb Stephen Warren:
>>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> This provides runtime test coverage in Travis, in addition to the existing
>> build coverage.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>>   .travis.yml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>
>
> Very nice, thanks!
>
> Reviewed-by: Heiko Schocher <hs@denx.de>
>
> bye,
> Heiko
>
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 8caaeb34553e..18bf2ed4fcdb 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -16,6 +16,8 @@ addons:
>>       - bc
>>       - build-essential
>>       - libsdl1.2-dev
>> +    - python
>> +    - python-virtualenv
>>
>>   cache:
>>    - apt
>> @@ -38,6 +40,9 @@ install:
>>    - echo -e "\n\n[toolchain-alias]\n${BUILDMAN_ALIAS} i386\n" >>
>> ~/.buildman
>>    - echo -e "${BUILDMAN_ALIAS_ARM} armv5te\n" >> ~/.buildman
>>    - cat ~/.buildman
>> + - virtualenv /tmp/venv
>> + - . /tmp/venv/bin/activate
>> + - pip install pytest
>>
>>   env:
>>     global:
>> @@ -177,5 +182,8 @@ matrix:
>>       # some statistics about the code base
>>       - env:
>>           - TEST_CMD="sloccount ."
>> +    # test/py
>> +    - env:
>> +        - TEST_CMD="./test/py/test.py --bd sandbox --build"
>>
>>   # TODO make it perfect ;-r
>>

Acked-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [U-Boot,2/2] Enable test/py for sandbox in Travis CI
  2016-02-09  1:23 ` [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI Stephen Warren
  2016-02-09 12:13   ` Meier, Roger
  2016-02-11  5:41   ` Heiko Schocher
@ 2016-02-15 22:36   ` Tom Rini
  2 siblings, 0 replies; 8+ messages in thread
From: Tom Rini @ 2016-02-15 22:36 UTC (permalink / raw)
  To: u-boot

On Mon, Feb 08, 2016 at 06:23:35PM -0700, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> This provides runtime test coverage in Travis, in addition to the existing
> build coverage.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Roger Meier <r.meier@siemens.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160215/7b897df0/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [PATCH 1/2] test/py: don't import pexpect
  2016-02-09  1:23 [U-Boot] [PATCH 1/2] test/py: don't import pexpect Stephen Warren
  2016-02-09  1:23 ` [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI Stephen Warren
@ 2016-02-15  1:19 ` Simon Glass
  2016-02-15 22:36 ` [U-Boot] [U-Boot,1/2] " Tom Rini
  2 siblings, 0 replies; 8+ messages in thread
From: Simon Glass @ 2016-02-15  1:19 UTC (permalink / raw)
  To: u-boot

On 8 February 2016 at 18:23, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The code replaced pexpect with custom code long ago. Don't import the
> unused module so it doesn't need to be installed.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  test/py/conftest.py | 1 -
>  1 file changed, 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [U-Boot] [U-Boot,1/2] test/py: don't import pexpect
  2016-02-09  1:23 [U-Boot] [PATCH 1/2] test/py: don't import pexpect Stephen Warren
  2016-02-09  1:23 ` [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI Stephen Warren
  2016-02-15  1:19 ` [U-Boot] [PATCH 1/2] test/py: don't import pexpect Simon Glass
@ 2016-02-15 22:36 ` Tom Rini
  2 siblings, 0 replies; 8+ messages in thread
From: Tom Rini @ 2016-02-15 22:36 UTC (permalink / raw)
  To: u-boot

On Mon, Feb 08, 2016 at 06:23:34PM -0700, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> The code replaced pexpect with custom code long ago. Don't import the
> unused module so it doesn't need to be installed.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160215/79ac0506/attachment.sig>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-02-15 22:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-09  1:23 [U-Boot] [PATCH 1/2] test/py: don't import pexpect Stephen Warren
2016-02-09  1:23 ` [U-Boot] [PATCH 2/2] Enable test/py for sandbox in Travis CI Stephen Warren
2016-02-09 12:13   ` Meier, Roger
2016-02-11  5:41   ` Heiko Schocher
2016-02-15  1:19     ` Simon Glass
2016-02-15 22:36   ` [U-Boot] [U-Boot,2/2] " Tom Rini
2016-02-15  1:19 ` [U-Boot] [PATCH 1/2] test/py: don't import pexpect Simon Glass
2016-02-15 22:36 ` [U-Boot] [U-Boot,1/2] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox