public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: Enable ethernet PHY configuration to RGMII again
Date: Thu, 11 Feb 2016 21:58:37 +0100	[thread overview]
Message-ID: <56BCF5FD.3010905@denx.de> (raw)
In-Reply-To: <CAPnjgZ2FxP0qzb75-avKFQiPMZEQ8zz+8JanbMdOnJMif4MpQQ@mail.gmail.com>

On 02/11/2016 09:28 PM, Simon Glass wrote:
> Hi,
> 
> On 11 February 2016 at 08:54, Stefan Roese <sr@denx.de> wrote:
>> On 11.02.2016 16:49, Marek Vasut wrote:
>>>
>>> On 02/11/2016 04:45 PM, Stefan Roese wrote:
>>>>
>>>> With commit c32a6fd0 [net: Don't call board/cpu_eth_init() with driver
>>>> model], cpu_eth_init() is not called on SoCFPGA any more. Since this
>>>> function configures the internal PHY interface to RGMII (via the physel_X
>>>> bits), its still needed. So lets rename this function and call it in
>>>> arch_early_init_r().
>>>>
>>>> Tested on socfpga_sr1500.
>>>>
>>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>>> Cc: Simon Glass <sjg@chromium.org>
>>>> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
>>>> Cc: Marek Vasut <marex@denx.de>
>>>> ---
>>>>   arch/arm/mach-socfpga/misc.c | 6 +++++-
>>>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/mach-socfpga/misc.c b/arch/arm/mach-socfpga/misc.c
>>>> index 9b43b92..2b1cd4a 100644
>>>> --- a/arch/arm/mach-socfpga/misc.c
>>>> +++ b/arch/arm/mach-socfpga/misc.c
>>>> @@ -104,7 +104,7 @@ static void dwmac_deassert_reset(const unsigned int
>>>> of_reset_id)
>>>>         socfpga_per_reset(reset, 0);
>>>>   }
>>>
>>>
>>> I just sent and applied very similar patch, can you try
>>> u-boot-socfpga/master and see if it works for you?
>>
>>
>> Done and works just fine. So please feel free to upstream your patch
>> version.
> 
> Can this be done in the driver? You have a device tree representation
> I think. If you are using the compat list in fdtdec.c then it suggests
> that you need a driver.

Does u-boot DM already have the ability to handle resets of various IP
blocks on the chip ? I don't think so, so for now I'll opt for fixing
this breakage.

  reply	other threads:[~2016-02-11 20:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 15:45 [U-Boot] [PATCH] arm: socfpga: Enable ethernet PHY configuration to RGMII again Stefan Roese
2016-02-11 15:49 ` Marek Vasut
2016-02-11 15:54   ` Stefan Roese
2016-02-11 20:28     ` Simon Glass
2016-02-11 20:58       ` Marek Vasut [this message]
2016-02-12  0:10         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BCF5FD.3010905@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox