* [U-Boot] [PATCH] fastboot: update error and warning messages
@ 2016-01-27 23:02 Steve Rae
2016-01-27 23:42 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Steve Rae @ 2016-01-27 23:02 UTC (permalink / raw)
To: u-boot
Fix the formatting in error messages, and demote one error message
to a warning, as it is only informational.
Signed-off-by: Steve Rae <srae@broadcom.com>
---
drivers/usb/gadget/f_fastboot.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
index 87e54eb..a54b4ee 100644
--- a/drivers/usb/gadget/f_fastboot.c
+++ b/drivers/usb/gadget/f_fastboot.c
@@ -382,7 +382,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req)
strsep(&cmd, ":");
if (!cmd) {
- error("missing variable\n");
+ error("missing variable");
fastboot_tx_write_str("FAILmissing var");
return;
}
@@ -413,7 +413,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req)
else
strcpy(response, "FAILValue not set");
} else {
- error("unknown variable: %s\n", cmd);
+ printf("WARNING: unknown variable: %s\n", cmd);
strcpy(response, "FAILVariable not implemented");
}
fastboot_tx_write_str(response);
@@ -561,7 +561,7 @@ static void cb_flash(struct usb_ep *ep, struct usb_request *req)
strsep(&cmd, ":");
if (!cmd) {
- error("missing partition name\n");
+ error("missing partition name");
fastboot_tx_write_str("FAILmissing partition name");
return;
}
@@ -683,7 +683,7 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req)
}
if (!func_cb) {
- error("unknown command: %s\n", cmdbuf);
+ error("unknown command: %s", cmdbuf);
fastboot_tx_write_str("FAILunknown command");
} else {
if (req->actual < req->length) {
@@ -691,7 +691,7 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req)
buf[req->actual] = 0;
func_cb(ep, req);
} else {
- error("buffer overflow\n");
+ error("buffer overflow");
fastboot_tx_write_str("FAILbuffer overflow");
}
}
--
1.8.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fastboot: update error and warning messages
2016-01-27 23:02 [U-Boot] [PATCH] fastboot: update error and warning messages Steve Rae
@ 2016-01-27 23:42 ` Marek Vasut
2016-02-16 1:20 ` Steve Rae
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2016-01-27 23:42 UTC (permalink / raw)
To: u-boot
On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote:
> Fix the formatting in error messages, and demote one error message
> to a warning, as it is only informational.
>
> Signed-off-by: Steve Rae <srae@broadcom.com>
I'd leave this to Lukasz, if he doesn't respond, ping me in a week or so.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fastboot: update error and warning messages
2016-01-27 23:42 ` Marek Vasut
@ 2016-02-16 1:20 ` Steve Rae
2016-02-16 2:35 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Steve Rae @ 2016-02-16 1:20 UTC (permalink / raw)
To: u-boot
ping -- Thanks!
On 16-01-27 03:42 PM, Marek Vasut wrote:
> On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote:
>> Fix the formatting in error messages, and demote one error message
>> to a warning, as it is only informational.
>>
>> Signed-off-by: Steve Rae <srae@broadcom.com>
>
> I'd leave this to Lukasz, if he doesn't respond, ping me in a week or so.
>
> Best regards,
> Marek Vasut
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fastboot: update error and warning messages
2016-02-16 1:20 ` Steve Rae
@ 2016-02-16 2:35 ` Marek Vasut
2016-02-16 9:07 ` Lukasz Majewski
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2016-02-16 2:35 UTC (permalink / raw)
To: u-boot
On 02/16/2016 02:20 AM, Steve Rae wrote:
> ping -- Thanks!
>
> On 16-01-27 03:42 PM, Marek Vasut wrote:
>> On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote:
>>> Fix the formatting in error messages, and demote one error message
>>> to a warning, as it is only informational.
>>>
>>> Signed-off-by: Steve Rae <srae@broadcom.com>
>>
>> I'd leave this to Lukasz, if he doesn't respond, ping me in a week or so.
>>
>> Best regards,
>> Marek Vasut
>>
Applied to u-boot-usb/master, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] fastboot: update error and warning messages
2016-02-16 2:35 ` Marek Vasut
@ 2016-02-16 9:07 ` Lukasz Majewski
0 siblings, 0 replies; 5+ messages in thread
From: Lukasz Majewski @ 2016-02-16 9:07 UTC (permalink / raw)
To: u-boot
Hi Marek,
> On 02/16/2016 02:20 AM, Steve Rae wrote:
> > ping -- Thanks!
> >
> > On 16-01-27 03:42 PM, Marek Vasut wrote:
> >> On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote:
> >>> Fix the formatting in error messages, and demote one error message
> >>> to a warning, as it is only informational.
> >>>
> >>> Signed-off-by: Steve Rae <srae@broadcom.com>
> >>
> >> I'd leave this to Lukasz, if he doesn't respond, ping me in a week
> >> or so.
> >>
> >> Best regards,
> >> Marek Vasut
> >>
>
> Applied to u-boot-usb/master, thanks!
>
+1
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-16 9:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 23:02 [U-Boot] [PATCH] fastboot: update error and warning messages Steve Rae
2016-01-27 23:42 ` Marek Vasut
2016-02-16 1:20 ` Steve Rae
2016-02-16 2:35 ` Marek Vasut
2016-02-16 9:07 ` Lukasz Majewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox