From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 16 Feb 2016 14:38:25 -0700
Subject: [U-Boot] test/py main_signon
In-Reply-To: <CAHTX3dK3_Kx7yGL4RnMb3a9qEQj8pJ3cbmX5is3_Vgc20tDtUw@mail.gmail.com>
References: <56C3121E.7060406@xilinx.com> <56C324F8.6090106@denx.de>
 <56C3487B.5070802@xilinx.com> <56C350C7.90804@wwwdotorg.org>
 <CAHTX3dK3_Kx7yGL4RnMb3a9qEQj8pJ3cbmX5is3_Vgc20tDtUw@mail.gmail.com>
Message-ID: <56C396D1.1050704@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/16/2016 12:08 PM, Michal Simek wrote:
> Hi Stephen,
>
> 2016-02-16 17:39 GMT+01:00 Stephen Warren <swarren@wwwdotorg.org
> <mailto:swarren@wwwdotorg.org>>:
>
>     On 02/16/2016 09:04 AM, Michal Simek wrote:
>
>         Hi Heiko,
>
>         On 16.2.2016 14:32, Heiko Schocher wrote:
>
>             Hello Michal,
>
>             Am 16.02.2016 um 13:12 schrieb Michal Simek:
>
>                 Hi Stephen,
>
>                 trying to run the latest testing on zynq board and
>                 getting this
>                 main_signon error.
>
>                 This is what I am running
>                 ./test/py/test.py --bd zynq_zc702  --build
>                 --board-identity zc702
>                 and getting below.
>
>
>             Does this board has SPL support without SPL serial output?
>
>
>         I do load u-boot via jtag that's why SPL logs are not visible.
>
>             If so, can you try my patch:
>             http://patchwork.ozlabs.org/patch/583348/
>
>
>         I have applied your patch but it is still not working.
>
>         If I run full flow with SPL then I can't see any issue.
>
>
>     I assume this is resolved then?
>
>
> Unfortunately both cases should work because SPL is not only one first
> stage bootloader
> which can be used. I didn't test zynqmp but there is no SPL and the same
> problem is
> probably there too. Or is there any dependency that if SPL is not build
> than testing system
> is not expecting it?
>
> I will look tmr at jtag boot mode with SPL if I can get it work.

The test scripts currently assume that if SPL is enabled in the U-Boot 
configuration file, then U-Boot SPL will run and print its signon 
message to the serial console. If you're starting U-Boot using a 
technique that invalidates this assumption, it won't work currently, as 
you found.

It's pretty easy to add a flag in the boardenv file to tell the system 
not to expect SPL signon. If you take a look at my second suggestion in:

http://lists.denx.de/pipermail/u-boot/2016-February/245759.html
[U-Boot] [PATCH] test/py: only check for SPL signature if SPL uses 
serial output

... then it's probably a simple as adding a third variable into the if 
condition, where that variable gets looks up from the "board 
environment", similar to:

spl_skipped = u_boot_console.config.env.get('env__spl_skipped', False)