From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] test/py: only check for SPL signature if SPL uses serial output
Date: Wed, 17 Feb 2016 18:30:22 +0100 [thread overview]
Message-ID: <56C4AE2E.4060101@denx.de> (raw)
In-Reply-To: <56C4A3C7.2070308@wwwdotorg.org>
Hello Stephen,
Am 17.02.2016 um 17:45 schrieb Stephen Warren:
> On 02/16/2016 11:48 PM, Heiko Schocher wrote:
>> check for U-Boot SPL signature only if SPL really has a serial output.
>> So check if CONFIG_SPL_SERIAL_SUPPORT is active in board config.
>
> I suspect you didn't test this; it causes all tests to fail on all platforms...
Damn, yes, seems I overlooked this issue, while trying to get
test/py running for the smartweb board.
>> diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
>
>> + bcfg = u_boot_console.config.buildconfig
>
> I think that should be self.config.buildconfig instead; there is no u_boot_console variable at this
> point in the code.
fixed.
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2016-02-17 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 6:48 [U-Boot] [PATCH v2] test/py: only check for SPL signature if SPL uses serial output Heiko Schocher
2016-02-17 16:45 ` Stephen Warren
2016-02-17 17:30 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C4AE2E.4060101@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox