From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Wed, 17 Feb 2016 18:30:22 +0100
Subject: [U-Boot] [PATCH v2] test/py: only check for SPL signature if
 SPL uses serial output
In-Reply-To: <56C4A3C7.2070308@wwwdotorg.org>
References: <1455691717-17728-1-git-send-email-hs@denx.de>
 <56C4A3C7.2070308@wwwdotorg.org>
Message-ID: <56C4AE2E.4060101@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Stephen,

Am 17.02.2016 um 17:45 schrieb Stephen Warren:
> On 02/16/2016 11:48 PM, Heiko Schocher wrote:
>> check for U-Boot SPL signature only if SPL really has a serial output.
>> So check if CONFIG_SPL_SERIAL_SUPPORT is active in board config.
>
> I suspect you didn't test this; it causes all tests to fail on all platforms...

Damn, yes, seems I overlooked this issue, while trying to get
test/py running for the smartweb board.

>> diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
>
>> +            bcfg = u_boot_console.config.buildconfig
>
> I think that should be self.config.buildconfig instead; there is no u_boot_console variable at this
> point in the code.

fixed.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany