public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] ls1021aqds_nor_lpuart_ boards
Date: Mon, 22 Feb 2016 07:44:32 +0100	[thread overview]
Message-ID: <56CAAE50.1010902@denx.de> (raw)
In-Reply-To: <56CA7E32.1080108@toradex.com>

Hi,

On 22/02/2016 04:19, Bhuvanchandra DV wrote:
> Hi Stefano,
> 
> Adding Bin Meng.
> 
> On 02/21/2016 05:01 PM, Stefano Babic wrote:
>> Hi Bhuvanchandra,
>>
>> your applied patch:
>>
>> commit 5160def267739518950e8e3bb78e0e6c3941cb3e
>> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> Date:   Wed Jan 27 10:31:52 2016 +0530
>>
>>      dm: lpuart: Drop the legacy code
>>
>> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this
>> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for
>> these boards (setting them, build is fine):
>>
>> For example, for ls1021aqds_nor_lpuart:
>> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
>> b/configs/ls1021aqds_nor_lpuart_defconfig
>> index 1186af2..d8d77c2 100644
>> --- a/configs/ls1021aqds_nor_lpuart_defconfig
>> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
>> @@ -2,6 +2,8 @@ CONFIG_ARM=y
>>   CONFIG_TARGET_LS1021AQDS=y
>>   CONFIG_SYS_EXTRA_OPTIONS="LPUART"
>>   # CONFIG_CMD_SETEXPR is not set
>> +CONFIG_DM=y
>> +CONFIG_DM_SERIAL=y
>>   CONFIG_NETDEVICES=y
>>   CONFIG_E1000=y
>>   CONFIG_FSL_LPUART=y
>>
>> Can you provide a formal patch and resubmit ? I have no way to test the
>> result on the board.
> 
> I also don't have this h/w to test at my end, may be Bin can help here.

Fabio has already added Alison who is board maintainer - the one could
have the hw for test.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      reply	other threads:[~2016-02-22  6:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 11:31 [U-Boot] ls1021aqds_nor_lpuart_ boards Stefano Babic
2016-02-21 13:00 ` Fabio Estevam
2016-02-22  1:44   ` Bin Meng
2016-02-22  7:08     ` Huan Wang
2016-02-22  3:19 ` Bhuvanchandra DV
2016-02-22  6:44   ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CAAE50.1010902@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox