* [U-Boot] ls1021aqds_nor_lpuart_ boards
@ 2016-02-21 11:31 Stefano Babic
2016-02-21 13:00 ` Fabio Estevam
2016-02-22 3:19 ` Bhuvanchandra DV
0 siblings, 2 replies; 6+ messages in thread
From: Stefano Babic @ 2016-02-21 11:31 UTC (permalink / raw)
To: u-boot
Hi Bhuvanchandra,
your applied patch:
commit 5160def267739518950e8e3bb78e0e6c3941cb3e
Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Date: Wed Jan 27 10:31:52 2016 +0530
dm: lpuart: Drop the legacy code
braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this
should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for
these boards (setting them, build is fine):
For example, for ls1021aqds_nor_lpuart:
diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
b/configs/ls1021aqds_nor_lpuart_defconfig
index 1186af2..d8d77c2 100644
--- a/configs/ls1021aqds_nor_lpuart_defconfig
+++ b/configs/ls1021aqds_nor_lpuart_defconfig
@@ -2,6 +2,8 @@ CONFIG_ARM=y
CONFIG_TARGET_LS1021AQDS=y
CONFIG_SYS_EXTRA_OPTIONS="LPUART"
# CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
+CONFIG_DM_SERIAL=y
CONFIG_NETDEVICES=y
CONFIG_E1000=y
CONFIG_FSL_LPUART=y
Can you provide a formal patch and resubmit ? I have no way to test the
result on the board.
Thanks,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] ls1021aqds_nor_lpuart_ boards
2016-02-21 11:31 [U-Boot] ls1021aqds_nor_lpuart_ boards Stefano Babic
@ 2016-02-21 13:00 ` Fabio Estevam
2016-02-22 1:44 ` Bin Meng
2016-02-22 3:19 ` Bhuvanchandra DV
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2016-02-21 13:00 UTC (permalink / raw)
To: u-boot
On Sun, Feb 21, 2016 at 8:31 AM, Stefano Babic <sbabic@denx.de> wrote:
> Hi Bhuvanchandra,
>
> your applied patch:
>
> commit 5160def267739518950e8e3bb78e0e6c3941cb3e
> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> Date: Wed Jan 27 10:31:52 2016 +0530
>
> dm: lpuart: Drop the legacy code
>
> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this
> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for
> these boards (setting them, build is fine):
>
> For example, for ls1021aqds_nor_lpuart:
> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
> b/configs/ls1021aqds_nor_lpuart_defconfig
> index 1186af2..d8d77c2 100644
> --- a/configs/ls1021aqds_nor_lpuart_defconfig
> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
> @@ -2,6 +2,8 @@ CONFIG_ARM=y
> CONFIG_TARGET_LS1021AQDS=y
> CONFIG_SYS_EXTRA_OPTIONS="LPUART"
> # CONFIG_CMD_SETEXPR is not set
> +CONFIG_DM=y
> +CONFIG_DM_SERIAL=y
> CONFIG_NETDEVICES=y
> CONFIG_E1000=y
> CONFIG_FSL_LPUART=y
>
> Can you provide a formal patch and resubmit ? I have no way to test the
> result on the board.
Adding Alison, who is the maintainer of this board and could probably
help testing the patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] ls1021aqds_nor_lpuart_ boards
2016-02-21 13:00 ` Fabio Estevam
@ 2016-02-22 1:44 ` Bin Meng
2016-02-22 7:08 ` Huan Wang
0 siblings, 1 reply; 6+ messages in thread
From: Bin Meng @ 2016-02-22 1:44 UTC (permalink / raw)
To: u-boot
On Sun, Feb 21, 2016 at 9:00 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Sun, Feb 21, 2016 at 8:31 AM, Stefano Babic <sbabic@denx.de> wrote:
>> Hi Bhuvanchandra,
>>
>> your applied patch:
>>
>> commit 5160def267739518950e8e3bb78e0e6c3941cb3e
>> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> Date: Wed Jan 27 10:31:52 2016 +0530
>>
>> dm: lpuart: Drop the legacy code
>>
>> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this
>> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for
>> these boards (setting them, build is fine):
>>
>> For example, for ls1021aqds_nor_lpuart:
>> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
>> b/configs/ls1021aqds_nor_lpuart_defconfig
>> index 1186af2..d8d77c2 100644
>> --- a/configs/ls1021aqds_nor_lpuart_defconfig
>> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
>> @@ -2,6 +2,8 @@ CONFIG_ARM=y
>> CONFIG_TARGET_LS1021AQDS=y
>> CONFIG_SYS_EXTRA_OPTIONS="LPUART"
>> # CONFIG_CMD_SETEXPR is not set
>> +CONFIG_DM=y
>> +CONFIG_DM_SERIAL=y
>> CONFIG_NETDEVICES=y
>> CONFIG_E1000=y
>> CONFIG_FSL_LPUART=y
>>
>> Can you provide a formal patch and resubmit ? I have no way to test the
>> result on the board.
>
> Adding Alison, who is the maintainer of this board and could probably
> help testing the patch.
There is already a series [1] for the ls1021a-qds.
[1] http://patchwork.ozlabs.org/patch/580577/
Regards,
Bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] ls1021aqds_nor_lpuart_ boards
2016-02-22 1:44 ` Bin Meng
@ 2016-02-22 7:08 ` Huan Wang
0 siblings, 0 replies; 6+ messages in thread
From: Huan Wang @ 2016-02-22 7:08 UTC (permalink / raw)
To: u-boot
> On Sun, Feb 21, 2016 at 9:00 PM, Fabio Estevam <festevam@gmail.com>
> wrote:
> > On Sun, Feb 21, 2016 at 8:31 AM, Stefano Babic <sbabic@denx.de> wrote:
> >> Hi Bhuvanchandra,
> >>
> >> your applied patch:
> >>
> >> commit 5160def267739518950e8e3bb78e0e6c3941cb3e
> >> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> >> Date: Wed Jan 27 10:31:52 2016 +0530
> >>
> >> dm: lpuart: Drop the legacy code
> >>
> >> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this
> >> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set
> >> for these boards (setting them, build is fine):
> >>
> >> For example, for ls1021aqds_nor_lpuart:
> >> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
> >> b/configs/ls1021aqds_nor_lpuart_defconfig
> >> index 1186af2..d8d77c2 100644
> >> --- a/configs/ls1021aqds_nor_lpuart_defconfig
> >> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
> >> @@ -2,6 +2,8 @@ CONFIG_ARM=y
> >> CONFIG_TARGET_LS1021AQDS=y
> >> CONFIG_SYS_EXTRA_OPTIONS="LPUART"
> >> # CONFIG_CMD_SETEXPR is not set
> >> +CONFIG_DM=y
> >> +CONFIG_DM_SERIAL=y
> >> CONFIG_NETDEVICES=y
> >> CONFIG_E1000=y
> >> CONFIG_FSL_LPUART=y
> >>
> >> Can you provide a formal patch and resubmit ? I have no way to test
> >> the result on the board.
> >
> > Adding Alison, who is the maintainer of this board and could probably
> > help testing the patch.
>
> There is already a series [1] for the ls1021a-qds.
>
> [1] http://patchwork.ozlabs.org/patch/580577/
[Alison Wang] Yes, York has sent a series to fix this problem.
I only review and test his series.
Best Regards,
Alison Wang
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] ls1021aqds_nor_lpuart_ boards
2016-02-21 11:31 [U-Boot] ls1021aqds_nor_lpuart_ boards Stefano Babic
2016-02-21 13:00 ` Fabio Estevam
@ 2016-02-22 3:19 ` Bhuvanchandra DV
2016-02-22 6:44 ` Stefano Babic
1 sibling, 1 reply; 6+ messages in thread
From: Bhuvanchandra DV @ 2016-02-22 3:19 UTC (permalink / raw)
To: u-boot
Hi Stefano,
Adding Bin Meng.
On 02/21/2016 05:01 PM, Stefano Babic wrote:
> Hi Bhuvanchandra,
>
> your applied patch:
>
> commit 5160def267739518950e8e3bb78e0e6c3941cb3e
> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> Date: Wed Jan 27 10:31:52 2016 +0530
>
> dm: lpuart: Drop the legacy code
>
> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this
> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for
> these boards (setting them, build is fine):
>
> For example, for ls1021aqds_nor_lpuart:
> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
> b/configs/ls1021aqds_nor_lpuart_defconfig
> index 1186af2..d8d77c2 100644
> --- a/configs/ls1021aqds_nor_lpuart_defconfig
> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
> @@ -2,6 +2,8 @@ CONFIG_ARM=y
> CONFIG_TARGET_LS1021AQDS=y
> CONFIG_SYS_EXTRA_OPTIONS="LPUART"
> # CONFIG_CMD_SETEXPR is not set
> +CONFIG_DM=y
> +CONFIG_DM_SERIAL=y
> CONFIG_NETDEVICES=y
> CONFIG_E1000=y
> CONFIG_FSL_LPUART=y
>
> Can you provide a formal patch and resubmit ? I have no way to test the
> result on the board.
I also don't have this h/w to test at my end, may be Bin can help here.
>
> Thanks,
> Stefano Babic
>
--
Best regards,
Bhuvan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] ls1021aqds_nor_lpuart_ boards
2016-02-22 3:19 ` Bhuvanchandra DV
@ 2016-02-22 6:44 ` Stefano Babic
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2016-02-22 6:44 UTC (permalink / raw)
To: u-boot
Hi,
On 22/02/2016 04:19, Bhuvanchandra DV wrote:
> Hi Stefano,
>
> Adding Bin Meng.
>
> On 02/21/2016 05:01 PM, Stefano Babic wrote:
>> Hi Bhuvanchandra,
>>
>> your applied patch:
>>
>> commit 5160def267739518950e8e3bb78e0e6c3941cb3e
>> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> Date: Wed Jan 27 10:31:52 2016 +0530
>>
>> dm: lpuart: Drop the legacy code
>>
>> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this
>> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for
>> these boards (setting them, build is fine):
>>
>> For example, for ls1021aqds_nor_lpuart:
>> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig
>> b/configs/ls1021aqds_nor_lpuart_defconfig
>> index 1186af2..d8d77c2 100644
>> --- a/configs/ls1021aqds_nor_lpuart_defconfig
>> +++ b/configs/ls1021aqds_nor_lpuart_defconfig
>> @@ -2,6 +2,8 @@ CONFIG_ARM=y
>> CONFIG_TARGET_LS1021AQDS=y
>> CONFIG_SYS_EXTRA_OPTIONS="LPUART"
>> # CONFIG_CMD_SETEXPR is not set
>> +CONFIG_DM=y
>> +CONFIG_DM_SERIAL=y
>> CONFIG_NETDEVICES=y
>> CONFIG_E1000=y
>> CONFIG_FSL_LPUART=y
>>
>> Can you provide a formal patch and resubmit ? I have no way to test the
>> result on the board.
>
> I also don't have this h/w to test at my end, may be Bin can help here.
Fabio has already added Alison who is board maintainer - the one could
have the hw for test.
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-22 7:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-21 11:31 [U-Boot] ls1021aqds_nor_lpuart_ boards Stefano Babic
2016-02-21 13:00 ` Fabio Estevam
2016-02-22 1:44 ` Bin Meng
2016-02-22 7:08 ` Huan Wang
2016-02-22 3:19 ` Bhuvanchandra DV
2016-02-22 6:44 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox