From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: eth: fix memalign() parameter order
Date: Mon, 22 Feb 2016 09:56:37 -0700 [thread overview]
Message-ID: <56CB3DC5.7000305@wwwdotorg.org> (raw)
In-Reply-To: <56BE4BC4.7080308@denx.de>
On 02/12/2016 02:16 PM, Marek Vasut wrote:
> On 02/12/2016 10:15 PM, Joe Hershberger wrote:
>> On Fri, Feb 12, 2016 at 2:56 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> From: Stephen Warren <swarren@nvidia.com>
>>>
>>> The alignment and size were swapped, leading to malloc heap corruption.
>>>
>>> On my system, this sometimes caused U-Boot to crash during or after
>>> certain USB Ethernet operations.
>>>
>>> Fixes: c8c2797c3810 ("dm: usb: eth: Support driver model with USB Ethernet")
>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>
>> Yikes.
>>
>> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
>>
> Applied to u-boot-usb/master, thanks.
Thanks. Any chance of a pull request into mainline? This issue is
causing lots of crashing on one of the systems in my test setup, which
potentially masks other problems.
next prev parent reply other threads:[~2016-02-22 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 20:56 [U-Boot] [PATCH] usb: eth: fix memalign() parameter order Stephen Warren
2016-02-12 20:57 ` Marek Vasut
2016-02-12 21:09 ` Simon Glass
2016-02-12 21:15 ` Joe Hershberger
2016-02-12 21:16 ` Marek Vasut
2016-02-22 16:56 ` Stephen Warren [this message]
2016-02-24 18:16 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB3DC5.7000305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox