public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking
Date: Mon, 22 Feb 2016 10:29:48 -0700	[thread overview]
Message-ID: <56CB458C.4090409@wwwdotorg.org> (raw)
In-Reply-To: <bb299fe2ae9a1069251d555479d8b833f0abf10c.1456145535.git.michal.simek@xilinx.com>

On 02/22/2016 05:52 AM, Michal Simek wrote:
> Provide user option to skip SPL signature verification for cases where
> u-boot is build with SPL support but full U-Boot is also verified
> without SPL.
> If you want to support this feature please add env__spl_skipped = True
> to your boardenv configuration file.

Nit: Blank line between those paragraphs?

>
> For example Xilinx Zynq is using this feature where the same u-boot
> binary is checked with SPL and without SPL(with FSBL).

Nit: U-Boot not u-boot?

> diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py

>               config_spl = bcfg.get('config_spl', 'n') == 'y'
>               config_spl_serial_support = bcfg.get('config_spl_serial_support',
>                                                    'n') == 'y'
> -            if config_spl and config_spl_serial_support:
> +            config_spl_skip = self.config.env.get('env__spl_skipped',
> +                                                  False)

That's not a config file (.config or autoconf.mk), but a boardenv value. 
I'd suggest renaming it boardenv_spl_skipped or env_spl_skipped.

Tested-by: Stephen Warren <swarren@nvidia.com>

Once renamed,
Acked-by: Stephen Warren <swarren@nvidia.com>

  reply	other threads:[~2016-02-22 17:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 12:52 [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking Michal Simek
2016-02-22 17:29 ` Stephen Warren [this message]
2016-02-23  9:37   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CB458C.4090409@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox