* [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking
@ 2016-02-22 12:52 Michal Simek
2016-02-22 17:29 ` Stephen Warren
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2016-02-22 12:52 UTC (permalink / raw)
To: u-boot
Provide user option to skip SPL signature verification for cases where
u-boot is build with SPL support but full U-Boot is also verified
without SPL.
If you want to support this feature please add env__spl_skipped = True
to your boardenv configuration file.
For example Xilinx Zynq is using this feature where the same u-boot
binary is checked with SPL and without SPL(with FSBL).
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
test/py/u_boot_console_base.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
index d6502c6e64cb..e50885d51aa4 100644
--- a/test/py/u_boot_console_base.py
+++ b/test/py/u_boot_console_base.py
@@ -307,7 +307,9 @@ class ConsoleBase(object):
config_spl = bcfg.get('config_spl', 'n') == 'y'
config_spl_serial_support = bcfg.get('config_spl_serial_support',
'n') == 'y'
- if config_spl and config_spl_serial_support:
+ config_spl_skip = self.config.env.get('env__spl_skipped',
+ False)
+ if config_spl and config_spl_serial_support and not config_spl_skip:
m = self.p.expect([pattern_u_boot_spl_signon] +
self.bad_patterns)
if m != 0:
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking
2016-02-22 12:52 [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking Michal Simek
@ 2016-02-22 17:29 ` Stephen Warren
2016-02-23 9:37 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2016-02-22 17:29 UTC (permalink / raw)
To: u-boot
On 02/22/2016 05:52 AM, Michal Simek wrote:
> Provide user option to skip SPL signature verification for cases where
> u-boot is build with SPL support but full U-Boot is also verified
> without SPL.
> If you want to support this feature please add env__spl_skipped = True
> to your boardenv configuration file.
Nit: Blank line between those paragraphs?
>
> For example Xilinx Zynq is using this feature where the same u-boot
> binary is checked with SPL and without SPL(with FSBL).
Nit: U-Boot not u-boot?
> diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
> config_spl = bcfg.get('config_spl', 'n') == 'y'
> config_spl_serial_support = bcfg.get('config_spl_serial_support',
> 'n') == 'y'
> - if config_spl and config_spl_serial_support:
> + config_spl_skip = self.config.env.get('env__spl_skipped',
> + False)
That's not a config file (.config or autoconf.mk), but a boardenv value.
I'd suggest renaming it boardenv_spl_skipped or env_spl_skipped.
Tested-by: Stephen Warren <swarren@nvidia.com>
Once renamed,
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking
2016-02-22 17:29 ` Stephen Warren
@ 2016-02-23 9:37 ` Michal Simek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2016-02-23 9:37 UTC (permalink / raw)
To: u-boot
On 22.2.2016 18:29, Stephen Warren wrote:
> On 02/22/2016 05:52 AM, Michal Simek wrote:
>> Provide user option to skip SPL signature verification for cases where
>> u-boot is build with SPL support but full U-Boot is also verified
>> without SPL.
>> If you want to support this feature please add env__spl_skipped = True
>> to your boardenv configuration file.
>
> Nit: Blank line between those paragraphs?
fixed
>
>>
>> For example Xilinx Zynq is using this feature where the same u-boot
>> binary is checked with SPL and without SPL(with FSBL).
>
> Nit: U-Boot not u-boot?
fixed.
>
>> diff --git a/test/py/u_boot_console_base.py
>> b/test/py/u_boot_console_base.py
>
>> config_spl = bcfg.get('config_spl', 'n') == 'y'
>> config_spl_serial_support =
>> bcfg.get('config_spl_serial_support',
>> 'n') == 'y'
>> - if config_spl and config_spl_serial_support:
>> + config_spl_skip = self.config.env.get('env__spl_skipped',
>> + False)
>
> That's not a config file (.config or autoconf.mk), but a boardenv value.
> I'd suggest renaming it boardenv_spl_skipped or env_spl_skipped.
env_spl_skipped is used now.
Currently env__net_dhcp_server names are used. It is also board specific.
Maybe make sense to just rename all these to boardenv_XXX.
> Tested-by: Stephen Warren <swarren@nvidia.com>
>
> Once renamed,
> Acked-by: Stephen Warren <swarren@nvidia.com>
I have added to v2 but feel free to reply if I should do any change.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-23 9:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 12:52 [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking Michal Simek
2016-02-22 17:29 ` Stephen Warren
2016-02-23 9:37 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox