From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Tue, 23 Feb 2016 10:37:49 +0100 Subject: [U-Boot] [PATCH] test/py: Add option to skip SPL signature checking In-Reply-To: <56CB458C.4090409@wwwdotorg.org> References: <56CB458C.4090409@wwwdotorg.org> Message-ID: <56CC286D.5070200@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 22.2.2016 18:29, Stephen Warren wrote: > On 02/22/2016 05:52 AM, Michal Simek wrote: >> Provide user option to skip SPL signature verification for cases where >> u-boot is build with SPL support but full U-Boot is also verified >> without SPL. >> If you want to support this feature please add env__spl_skipped = True >> to your boardenv configuration file. > > Nit: Blank line between those paragraphs? fixed > >> >> For example Xilinx Zynq is using this feature where the same u-boot >> binary is checked with SPL and without SPL(with FSBL). > > Nit: U-Boot not u-boot? fixed. > >> diff --git a/test/py/u_boot_console_base.py >> b/test/py/u_boot_console_base.py > >> config_spl = bcfg.get('config_spl', 'n') == 'y' >> config_spl_serial_support = >> bcfg.get('config_spl_serial_support', >> 'n') == 'y' >> - if config_spl and config_spl_serial_support: >> + config_spl_skip = self.config.env.get('env__spl_skipped', >> + False) > > That's not a config file (.config or autoconf.mk), but a boardenv value. > I'd suggest renaming it boardenv_spl_skipped or env_spl_skipped. env_spl_skipped is used now. Currently env__net_dhcp_server names are used. It is also board specific. Maybe make sense to just rename all these to boardenv_XXX. > Tested-by: Stephen Warren > > Once renamed, > Acked-by: Stephen Warren I have added to v2 but feel free to reply if I should do any change. Thanks, Michal