From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/9] tegra: Replace home grown mmu code with generic table approach
Date: Tue, 23 Feb 2016 10:29:07 -0700 [thread overview]
Message-ID: <56CC96E3.7020308@wwwdotorg.org> (raw)
In-Reply-To: <56CC365A.3010300@xilinx.com>
On 02/23/2016 03:37 AM, Michal Simek wrote:
> On 22.2.2016 19:28, Stephen Warren wrote:
>> On 02/21/2016 06:57 PM, Alexander Graf wrote:
>>> Now that we have nice table driven page table creating code that gives
>>> us everything we need, move to that.
>>
>>> diff --git a/include/configs/tegra210-common.h
>>> b/include/configs/tegra210-common.h
>>
>>> +#define CONFIG_SYS_FULL_VA
>>> +#define CONFIG_SYS_MEM_MAP { \
>>> + { \
>>> + .base = 0x0UL, \
>>> + .size = 0x80000000UL, \
>>> + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | \
>>> + PTE_BLOCK_NON_SHARE | \
>>> + PTE_BLOCK_PXN | PTE_BLOCK_UXN \
>>> + }, { \
>>> + .base = 0x80000000UL, \
>>> + .size = 0xff80000000UL, \
>>> + .attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) | \
>>> + PTE_BLOCK_INNER_SHARE \
>>> + }, \
>>> + }
>>
>> I'd prefer a layout that didn't align the closing } for different
>> nesting levels in the same column. To avoid indenting everything a lot,
>> it seems simplest to pull the final } back into the first column.
>>
>> I believe the .size field of the second entry in the array only needs to
>> be 0x80000000. Testing with a PCIe Ethernet card on p2371-2180 (the
>> driver for which sets up noncached entries in the page tables, hence
>> should exercise all this code) confirms that.
>>
>> While recent Tegra systems do support more than 2GB of RAM, U-Boot will
>> itself only use the first 2GB, so that PAs over 4GB are not used. See
>> board_get_usable_ram_top() in arch/arm/mach-tegra/board2.c. That's
>> because some peripherals can only access 32-bit PAs, and the simplest
>> way to accommodate that is to ignore any RAM above the 32-bit limit.
>
> Didn't you use mtest to test memory above of 2GB?
It looks like we don't have mtest enabled.
However, I was able to use itest to confirm that RAM > 4GB PA does work
with this patch. I suppose we may as well leave it enabled then.
next prev parent reply other threads:[~2016-02-23 17:29 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 1:57 [U-Boot] [PATCH 0/9] arm64: Unify MMU code Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 1/9] thunderx: Calculate TCR dynamically Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 2/9] arm64: Make full va map code more dynamic Alexander Graf
2016-02-22 18:18 ` Stephen Warren
2016-02-22 18:37 ` Alexander Graf
2016-02-22 18:45 ` Stephen Warren
2016-02-24 10:21 ` Alexander Graf
2016-02-22 18:42 ` Stephen Warren
2016-02-23 13:17 ` Simon Glass
2016-02-23 17:21 ` Stephen Warren
2016-02-23 17:30 ` Simon Glass
2016-02-23 17:40 ` Stephen Warren
2016-02-23 20:00 ` Simon Glass
2016-02-23 20:33 ` Stephen Warren
2016-02-24 4:42 ` Simon Glass
2016-02-24 16:56 ` Stephen Warren
2016-02-24 10:55 ` Alexander Graf
2016-02-24 17:01 ` Stephen Warren
2016-02-24 17:04 ` Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 3/9] zymqmp: Replace home grown mmu code with generic table approach Alexander Graf
2016-02-23 11:04 ` Michal Simek
2016-02-23 11:33 ` Alexander Graf
2016-02-23 13:07 ` Michal Simek
2016-02-26 0:49 ` Alexander Graf
2016-02-26 8:29 ` Michal Simek
2016-02-26 8:55 ` Alexander Graf
2017-02-16 15:26 ` brettstahlman
2016-02-22 1:57 ` [U-Boot] [PATCH 4/9] tegra: " Alexander Graf
2016-02-22 18:28 ` Stephen Warren
2016-02-23 10:37 ` Michal Simek
2016-02-23 17:29 ` Stephen Warren [this message]
2016-02-24 10:28 ` Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 5/9] vexpress64: Add MMU tables Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 6/9] dwmmc: Increase retry timeout Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 7/9] hikey: Add MMU tables Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 8/9] arm64: Remove non-full-va map code Alexander Graf
2016-02-22 1:57 ` [U-Boot] [PATCH 9/9] arm64: Only allow dcache disabled in SPL builds Alexander Graf
2016-02-22 17:37 ` [U-Boot] [PATCH 0/9] arm64: Unify MMU code york sun
2016-02-22 18:02 ` Alexander Graf
2016-02-22 18:12 ` york sun
2016-02-22 18:31 ` Alexander Graf
2016-02-22 18:39 ` york sun
2016-02-22 19:42 ` Alexander Graf
2016-02-22 19:52 ` york sun
2016-02-22 20:09 ` Alexander Graf
2016-02-22 20:15 ` york sun
2016-02-24 10:19 ` Alexander Graf
2016-02-24 16:57 ` Stephen Warren
2016-02-22 18:34 ` Stephen Warren
2016-02-24 10:33 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC96E3.7020308@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox