public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: ns16550: Add support for reg-offset property
Date: Wed, 24 Feb 2016 12:26:09 +0100	[thread overview]
Message-ID: <56CD9351.20802@xilinx.com> (raw)
In-Reply-To: <CAHCN7x+wL9NvQA2hrRPfPNvRhPAkOD5+j_r-pd9_T=zNmNNZpg@mail.gmail.com>

On 24.2.2016 11:56, Adam Ford wrote:
> On Tue, Feb 23, 2016 at 12:38 AM, Simon Glass <sjg@chromium.org> wrote:
>> Hi Michal,
>>
>> On 22 February 2016 at 00:40, Michal Simek <michal.simek@xilinx.com> wrote:
>>> On 19.2.2016 21:55, Simon Glass wrote:
>>>> Hi Michal,
>>>>
>>>> On 16 February 2016 at 08:17, Michal Simek <michal.simek@xilinx.com> wrote:
>>>>> reg-offset is the part of standard 8250 binding in the kernel.
>>>>> It is shifting start of address space by reg-offset.
>>>>> On Xilinx platform this offset is typically 0x1000.
>>>>>
>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>>> ---
>>>>>
>>>>>  drivers/serial/ns16550.c | 6 ++++--
>>>>>  include/ns16550.h        | 1 +
>>>>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>>>
>>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>>
>>>> Do you support the debug UART feature on your boards?
>>>
>>> yes. I do support it but there you can put just address plus offset and
>>> there is no reason to add one more option to Kconfig.
>>> But let me know if you think that this is incorrect flow.
>>
> 
> This patch seems to break my OMAP3 board.  Does anyone know if I need
> to set a certain offset for OMAP3 to make this work (and where is the
> right place for it) ?

Are you using DT init? Check your DT description if there is reg-offset
property. I expect if your board worked before and you remove this
property it will start to work again.

Thanks,
Michal

  reply	other threads:[~2016-02-24 11:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 15:17 [U-Boot] [PATCH] dm: ns16550: Add support for reg-offset property Michal Simek
2016-02-19 20:55 ` Simon Glass
2016-02-22  7:40   ` Michal Simek
2016-02-23  6:38     ` Simon Glass
2016-02-24 10:56       ` Adam Ford
2016-02-24 11:26         ` Michal Simek [this message]
2016-02-24 22:47           ` Derald D. Woods
2016-02-25  0:33             ` Simon Glass
2016-02-25  3:05               ` Derald D. Woods
2016-02-25  4:47           ` Derald D. Woods
2016-02-25  8:11             ` Michal Simek
2016-02-25 13:38               ` Derald D. Woods
2016-02-28 22:39                 ` Alexander Graf
2016-02-28 23:45                   ` Derald D. Woods
2016-02-28 23:51                     ` Derald D. Woods
2016-02-29  3:56                       ` Adam Ford
2016-02-29  4:58                         ` Derald D. Woods
2016-02-29  5:15                           ` Simon Glass
2016-02-29  7:38                             ` Michal Simek
2016-03-13  1:54                   ` Simon Glass
2016-03-15 12:31                     ` Adam Ford
2016-03-31  9:16                     ` Michal Simek
2016-04-05  0:03                       ` Simon Glass
2016-04-05 11:39                         ` Michal Simek
2016-02-20  0:54 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CD9351.20802@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox