From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Wed, 24 Feb 2016 12:26:09 +0100 Subject: [U-Boot] [PATCH] dm: ns16550: Add support for reg-offset property In-Reply-To: References: <70bfc564698cfd32c932a382a98321be169ccd87.1455635867.git.michal.simek@xilinx.com> <56CABB54.8070901@xilinx.com> Message-ID: <56CD9351.20802@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 24.2.2016 11:56, Adam Ford wrote: > On Tue, Feb 23, 2016 at 12:38 AM, Simon Glass wrote: >> Hi Michal, >> >> On 22 February 2016 at 00:40, Michal Simek wrote: >>> On 19.2.2016 21:55, Simon Glass wrote: >>>> Hi Michal, >>>> >>>> On 16 February 2016 at 08:17, Michal Simek wrote: >>>>> reg-offset is the part of standard 8250 binding in the kernel. >>>>> It is shifting start of address space by reg-offset. >>>>> On Xilinx platform this offset is typically 0x1000. >>>>> >>>>> Signed-off-by: Michal Simek >>>>> --- >>>>> >>>>> drivers/serial/ns16550.c | 6 ++++-- >>>>> include/ns16550.h | 1 + >>>>> 2 files changed, 5 insertions(+), 2 deletions(-) >>>> >>>> Reviewed-by: Simon Glass >>>> >>>> Do you support the debug UART feature on your boards? >>> >>> yes. I do support it but there you can put just address plus offset and >>> there is no reason to add one more option to Kconfig. >>> But let me know if you think that this is incorrect flow. >> > > This patch seems to break my OMAP3 board. Does anyone know if I need > to set a certain offset for OMAP3 to make this work (and where is the > right place for it) ? Are you using DT init? Check your DT description if there is reg-offset property. I expect if your board worked before and you remove this property it will start to work again. Thanks, Michal