From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 25 Feb 2016 18:55:35 +0100 Subject: [U-Boot] [PATCH] serial: Move carriage return before line feed for some serial drivers In-Reply-To: <1456368085-19979-1-git-send-email-b18965@freescale.com> References: <1456368085-19979-1-git-send-email-b18965@freescale.com> Message-ID: <56CF4017.3040505@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/25/2016 03:41 AM, Alison Wang wrote: > In general, a carriage return needs to execute before a line feed. > The patch is to change some serial drivers based on this rule, such > as serial_mxc.c, serial_pxa.c, serial_s3c24x0.c and usbtty.c. > > Signed-off-by: Alison Wang Why isn't this CR-LF stuff handled in common code instead ? It'd be much better than having billion copies of the exact same logic (some of them more buggy than the others) in drivers.