From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] board:freescale:common: Move device-tree fixup framework to common file
Date: Fri, 26 Feb 2016 17:21:13 +0100 [thread overview]
Message-ID: <56D07B79.1070401@denx.de> (raw)
In-Reply-To: <AM2PR04MB0547453E11570BC94C9DC986F5A70@AM2PR04MB0547.eurprd04.prod.outlook.com>
On 02/26/2016 05:07 PM, Sriram Dash wrote:
> Please find my reply inline
Please stop top-posting.
Also please fix your mailer so it quotes correctly with '>'
> -----Original Message----- From: Marek Vasut [mailto:marex at denx.de]
> Sent: Thursday, February 25, 2016 11:28 PM To: Sriram Dash
> <sriram.dash@nxp.com>; u-boot at lists.denx.de Cc: york sun
> <york.sun@nxp.com>; Ramneek Mehresh <ramneek.mehresh@nxp.com>; Rajesh
> Bhagat <rajesh.bhagat@nxp.com> Subject: Re: [PATCH v2 1/2]
> board:freescale:common: Move device-tree fixup framework to common
> file
>
> On 02/24/2016 05:44 AM, Sriram Dash wrote:
>> Move usb device-tree fixup framework from ehci-fsl.c to common
>> place so that it can be used by other drivers as well
>> (xhci-fsl.c). Also, call fdt_usb_get_node_type() from
>> fdt_fixup_usb_mode_phy_type() to avoid code duplication.
>>
>> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@nxp.com>
>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>
> Is this just moving the code ? If so, please resubmit and use git
> format-patch -M -C to generate the patches for the submission. It
> makes it much easier to detect moved files.
>
> [Sriram] No, this patch is performing two actions:
>
> 1. Move usb device-tree fixup framework from ehci-fsl.c to common
> place so that it can be used by other drivers as well (xhci-fsl.c).
>
> 2. Call fdt_usb_get_node_type() from fdt_fixup_usb_mode_phy_type() to
> avoid code duplication.
Then it should be two patches.
next prev parent reply other threads:[~2016-02-26 16:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 11:36 [U-Boot] [PATCH 1/2] fsl:usb: Make fsl usb device-tree fixup arch independent Ramneek Mehresh
2016-01-26 11:27 ` Marek Vasut
2016-01-26 11:36 ` [U-Boot] [PATCH 2/2] include:configs: Add usb device-tree fixup for all fsl platforms Ramneek Mehresh
2016-01-26 11:28 ` Marek Vasut
2016-01-27 4:14 ` Ramneek Mehresh
2016-01-27 4:27 ` Marek Vasut
2016-01-27 4:30 ` Ramneek Mehresh
2016-01-27 7:35 ` Marek Vasut
2016-01-27 8:26 ` Ramneek Mehresh
2016-01-27 8:27 ` Marek Vasut
2016-01-27 11:33 ` Ramneek Mehresh
2016-01-27 11:42 ` Marek Vasut
2016-01-28 11:05 ` Ramneek Mehresh
2016-01-28 11:34 ` Marek Vasut
2016-01-28 12:15 ` Ramneek Mehresh
2016-02-08 11:07 ` Ramneek Mehresh
2016-02-08 15:26 ` Marek Vasut
2016-02-24 4:44 ` [U-Boot] [PATCH v2 0/2] Make usb device-tree fixup independent of USB controller Sriram Dash
2016-02-24 4:44 ` [U-Boot] [PATCH v2 1/2] board:freescale:common: Move device-tree fixup framework to common file Sriram Dash
2016-02-25 17:58 ` Marek Vasut
2016-02-26 16:07 ` Sriram Dash
2016-02-26 16:21 ` Marek Vasut [this message]
2016-02-24 4:44 ` [U-Boot] [PATCH v2 2/2] board:freescale:usb: Add device-tree fixup support for xhci controller Sriram Dash
2016-02-25 18:00 ` Marek Vasut
2016-02-26 16:19 ` Sriram Dash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D07B79.1070401@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox