From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 26 Feb 2016 17:21:13 +0100 Subject: [U-Boot] [PATCH v2 1/2] board:freescale:common: Move device-tree fixup framework to common file In-Reply-To: References: <1453808218-27599-1-git-send-email-ramneek.mehresh@freescale.com> <1456289048-9226-1-git-send-email-sriram.dash@nxp.com> <1456289048-9226-2-git-send-email-sriram.dash@nxp.com> <56CF40B2.9040407@denx.de> Message-ID: <56D07B79.1070401@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/26/2016 05:07 PM, Sriram Dash wrote: > Please find my reply inline Please stop top-posting. Also please fix your mailer so it quotes correctly with '>' > -----Original Message----- From: Marek Vasut [mailto:marex at denx.de] > Sent: Thursday, February 25, 2016 11:28 PM To: Sriram Dash > ; u-boot at lists.denx.de Cc: york sun > ; Ramneek Mehresh ; Rajesh > Bhagat Subject: Re: [PATCH v2 1/2] > board:freescale:common: Move device-tree fixup framework to common > file > > On 02/24/2016 05:44 AM, Sriram Dash wrote: >> Move usb device-tree fixup framework from ehci-fsl.c to common >> place so that it can be used by other drivers as well >> (xhci-fsl.c). Also, call fdt_usb_get_node_type() from >> fdt_fixup_usb_mode_phy_type() to avoid code duplication. >> >> Signed-off-by: Ramneek Mehresh >> Signed-off-by: Sriram Dash > > Is this just moving the code ? If so, please resubmit and use git > format-patch -M -C to generate the patches for the submission. It > makes it much easier to detect moved files. > > [Sriram] No, this patch is performing two actions: > > 1. Move usb device-tree fixup framework from ehci-fsl.c to common > place so that it can be used by other drivers as well (xhci-fsl.c). > > 2. Call fdt_usb_get_node_type() from fdt_fixup_usb_mode_phy_type() to > avoid code duplication. Then it should be two patches.