public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 2/2] Add support the Avionic Design Meerkat COM and Kein Baseboard
Date: Tue, 1 Mar 2016 10:30:17 -0700	[thread overview]
Message-ID: <56D5D1A9.9090708@wwwdotorg.org> (raw)
In-Reply-To: <1456819409-26418-2-git-send-email-julian@jusst.de>

On 03/01/2016 01:03 AM, Julian Scheel wrote:
> Add support for platforms based on the Meerkat COM module. Includes support
> for the minimal reference platform called Kein Baseboard, which in fact is
> sufficient to run most existing Meerkat carriers.
>
> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
> Changes in v2:
>   - Rename config options to TARGET_KEIN_BASEBOARD
>   - Remove unnecessary CONFIG options from kein-baseboard.h
>   - Remove bad as3722 gpio manipulations on pcie init

I think that point didn't actually happen:

> diff --git a/board/avionic-design/common/meerkat.c b/board/avionic-design/common/meerkat.c

> +int tegra_pcie_board_init(void)

> +	err = as3722_gpio_configure(pmic, 1, AS3722_GPIO_OUTPUT_VDDH |
> +					     AS3722_GPIO_INVERT);
> +	if (err < 0) {
> +		error("failed to configure GPIO#1 as output: %d\n", err);
> +		return err;
> +	}
> +
> +	err = as3722_gpio_direction_output(pmic, 2, 1);
> +	if (err < 0) {
> +		error("failed to set GPIO#2 high: %d\n", err);
> +		return err;
> +	}

Aside from that, the series,
Acked-by: Stephen Warren <swarren@nvidia.com>

      reply	other threads:[~2016-03-01 17:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01  8:03 [U-Boot] [PATCHv2 1/2] power: as3722: Allow using on any i2c bus with any address Julian Scheel
2016-03-01  8:03 ` [U-Boot] [PATCHv2 2/2] Add support the Avionic Design Meerkat COM and Kein Baseboard Julian Scheel
2016-03-01 17:30   ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D5D1A9.9090708@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox